From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id YJNiOwHQxGZ5+g0AWB0awg (envelope-from ) for ; Tue, 20 Aug 2024 13:18:57 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=NWUeW6mJ; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id EC5F21E0D0; Tue, 20 Aug 2024 13:18:57 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id D5B631E08C for ; Tue, 20 Aug 2024 13:18:55 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 921A438438AF for ; Tue, 20 Aug 2024 17:18:55 +0000 (GMT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id B8158384477A for ; Tue, 20 Aug 2024 17:18:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B8158384477A Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B8158384477A Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1724174316; cv=none; b=EAqIi47VRArgzL1/GH0nmCj62AQ1aeo2jare1SEMgs0bRMihT7FePC8SjzbmBTQdhYgVz6oWETcR6AJOcZdESgHd2Mn9El5nZfIRgRQNgsICj9XF2gSBmAkcKlYeE49DjapIbYOpHgG+NprFm119qkBvrW4hGiIIG+sa1HEFtY8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1724174316; c=relaxed/simple; bh=PT5Jh77ZX5XQaAv7NSra/HWtTi1f++hBkYtYsAQYoT0=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=pRpnpwWQeEntGF4J7WhPRby+cfYb0guSuJFE5fcb5dmtTRZoQV2IGZBeRjoLzbxLWPyNLMhNorywP72pa9Ln4qDAewuPCR4c5ZsFqZ8oT05cM6+s6aZyk923Ryg377edOvkLTISte2kXh+VqowNCN5s/hW41ayvjpq8c0do/BJo= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1724174315; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Fpc/b1yPVnd6/klacnPnejPDwn21naFapKcD1j0qKSw=; b=NWUeW6mJ1imme0Ve6hC6O8bgDLRoc5a3p5SksQPUPGRCf5gj52oGITEeW4QH3fPUVAtsns Z1774bVRUj/aq37rkb2Q1jx7FC7iXiAFzrN4Sv+3j4+xAUVBFnhw/z9RG+J52+jZ5OII0W h6uXnwXQRnHX+Zj54tsI8o0JIdsuHus= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-55-ybQpJqJTOBayZMb0xfmzoA-1; Tue, 20 Aug 2024 13:18:33 -0400 X-MC-Unique: ybQpJqJTOBayZMb0xfmzoA-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-428fb72245bso30788905e9.1 for ; Tue, 20 Aug 2024 10:18:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724174312; x=1724779112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Fpc/b1yPVnd6/klacnPnejPDwn21naFapKcD1j0qKSw=; b=p1cSO94kw/SG/a+r+dxArHrjkH0TSX/RSbZzoLZ/TtQ7B68EJe21z4vNnwn5muwqAv Wn7zv8KoteaLbMxTA/n9IQSiCbvcSTgB6BKwXUt0Ws0Sc1oTLOI34a7H/aZr36aRMW4D yY4Gu+/zpWtcvL7V7v0AGRZWRml7mI8W7XJy7cWoCHtF5IvVGgtmR78gGuuOAsg+ybyC q6HGoLF3k62pKieW6HI/lfTESlw4jQQljGhlI85mQoU+g+n0BE3aVAtQIiyFmptOFqLN rA5Kqom3QMWFbuFVLpJ8IhiHfwpSSfsKzk97P2mnrIZ9btqrxLwX6FHTkOvAwnLuC658 iT0g== X-Gm-Message-State: AOJu0YxRXkzYCiTnoKlfv2qiyrYoVCWNaqFxo65b8ye/jdya3Rh9okpM 9FZfIN2+mRyrNQbvn03MtJ4gFEgIwbXb+GfWMUn1b5BXdDze8toVNiFqPAcfPL4VOWgBbrzAU2U GDVrsFYx7GqQtL+16Bkh3xcp4qlvI3GJKiawe5HvPW/d6GvJwU7ojlrVYuDrB5DPd5Kk= X-Received: by 2002:a05:600c:1d0e:b0:426:526f:4a1f with SMTP id 5b1f17b1804b1-42ab56d6cdamr20850435e9.16.1724174311810; Tue, 20 Aug 2024 10:18:31 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGYGcT26+HLv7Mqtvj56bHY2F+1NnvPaGfe2sL17NuR+lmXTbui989i0yAbVZA0ssbrHlEo/A== X-Received: by 2002:a05:600c:1d0e:b0:426:526f:4a1f with SMTP id 5b1f17b1804b1-42ab56d6cdamr20850255e9.16.1724174311137; Tue, 20 Aug 2024 10:18:31 -0700 (PDT) Received: from localhost (178.126.90.146.dyn.plus.net. [146.90.126.178]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-429ded720fbsm206494705e9.35.2024.08.20.10.18.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Aug 2024 10:18:30 -0700 (PDT) From: Andrew Burgess To: Eli Zaretskii Cc: gdb-patches@sourceware.org Subject: Re: [PATCHv4 13/14] gdb: allow quoted filenames for commands that have custom completion In-Reply-To: <86ikxl88p9.fsf@gnu.org> References: <351179c8d62d8dbd971679c1322757eb35ff4713.1720101827.git.aburgess@redhat.com> <86ikxl88p9.fsf@gnu.org> Date: Tue, 20 Aug 2024 18:18:30 +0100 Message-ID: <87frqzw1sp.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Eli Zaretskii writes: >> From: Andrew Burgess >> Cc: Andrew Burgess >> Date: Thu, 4 Jul 2024 15:21:08 +0100 >> >> --- a/gdb/NEWS >> +++ b/gdb/NEWS >> @@ -23,6 +23,13 @@ remove-symbol-file -a ADDRESS >> multiple terms, e.g. 'function + 0x1000' (without quotes), >> previously only a single term could be given. >> >> +compile file >> +maint print c-tdesc >> +save gdb-index >> + These commands now require their filename argument to be quoted if >> + it contains with white space or quote characters. If the argument > ^^^^ > The "with" part should be removed. > > Also, are white space and quotes the only special characters for these > commands? Yes. GDB doesn't interpret any other special characters for these commands except ~ and quoting is not needed for that. > >> + contains no special characters then quoting is not required. > ^^^^^^^^^^^^^^^^^^^^^ > I suggest to say here "no such special characters", to make absolutely > clear that you are talking about white space and quotes mentioned > earlier by their names. I made this fix in the new version I posted. Thanks for all your feedback, Andrew > > Thanks. > > Reviewed-By: Eli Zaretskii