From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id KOq3FxqGiGcEoxAAWB0awg (envelope-from ) for ; Wed, 15 Jan 2025 23:07:54 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=sergiodj.net header.i=@sergiodj.net header.a=rsa-sha256 header.s=20160602 header.b=V+xR6R13; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 5E4661E100; Wed, 15 Jan 2025 23:07:54 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=unavailable autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id F0C4F1E08E for ; Wed, 15 Jan 2025 23:07:53 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 3AEF93851160 for ; Thu, 16 Jan 2025 04:07:53 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3AEF93851160 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=sergiodj.net header.i=@sergiodj.net header.a=rsa-sha256 header.s=20160602 header.b=V+xR6R13 Received: from mail.sergiodj.net (mail.sergiodj.net [195.201.110.160]) by sourceware.org (Postfix) with ESMTPS id EDB633857BA2 for ; Thu, 16 Jan 2025 04:07:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EDB633857BA2 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=sergiodj.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=sergiodj.net ARC-Filter: OpenARC Filter v1.0.0 sourceware.org EDB633857BA2 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.201.110.160 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1737000444; cv=none; b=CikfEGhn/PEgd2Cq174G1gKcKkCVX8LGRDagMUv3b4lzhvjRFIayCCh7iTGryOruoudrMraKegWHjERdEdQfsR2VCyyYicgAnSVaTh9CyT1OObrJKpItLFNEfeOvhVOO9yy6ew3EZPJ4rpaQAur62ctFoiMt9MyPDVZzfHMKWzY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1737000444; c=relaxed/simple; bh=vgzp/enwuRc36IeqU/HZ8mXnfAfemkUOgPq2FMFPdNY=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=CrWLQpKhjGjTKgmGgxOJrtaZxOUqgmxGJJJjrKDNShHmqPorOqrc2nBNpuNTRseAM+tRm5qVYq4g/pEmuByhtVfBj37e2N5zs7h8OBBr16Z0sl7crKFCyE6fUvBLlFuVlN/cYcs3nKD/tnKK6fWDNS+WTMBEEmJOUwyZVqD/FDY= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org EDB633857BA2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=sergiodj.net; s=20160602; t=1737000442; bh=vgzp/enwuRc36IeqU/HZ8mXnfAfemkUOgPq2FMFPdNY=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=V+xR6R13jCIRgOx83G0/ircK+GVk/gnR8hMQNne0q+nD1f0LBDo2BjULOYkpNTf6H 9iJouQ0IrYGiqxZr1RyQwlZh89IyKpN4VNOGJ6g2+sQtklZDMnEzhnSgWBwSY8755C izXQiqGjgvPv2jic3Rr9QIMscfS2JnWVfU8DtoW4= From: Sergio Durigan Junior To: Simon Marchi Cc: GDB Patches , Simon Marchi Subject: Re: [PATCH] gdbserver: Fix build on MIPS In-Reply-To: <6cb5835d-3c50-4fd1-a9a7-39ac2c1d66d6@simark.ca> (Simon Marchi's message of "Wed, 15 Jan 2025 21:26:19 -0500") References: <20250116011055.4022193-1-sergiodj@sergiodj.net> <6cb5835d-3c50-4fd1-a9a7-39ac2c1d66d6@simark.ca> X-URL: http://blog.sergiodj.net Date: Wed, 15 Jan 2025 23:07:20 -0500 Message-ID: <87frlj766f.fsf@sergiodj.net> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On Wednesday, January 15 2025, Simon Marchi wrote: > On 2025-01-15 20:10, Sergio Durigan Junior wrote: >> Commit 3470a0e144df6c01f8479fa649f43aa907936e7e inadvertently broke >> the build on MIPS because it's passing a non-existent "pid" argument >> to "proc->for_each_thread". This commit fixes the problem by removing >> the argument from the call. >> >> Signed-off-by: Sergio Durigan Junior >> --- >> gdbserver/linux-mips-low.cc | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/gdbserver/linux-mips-low.cc b/gdbserver/linux-mips-low.cc >> index 98733709fa3..fafcdefbb06 100644 >> --- a/gdbserver/linux-mips-low.cc >> +++ b/gdbserver/linux-mips-low.cc >> @@ -623,7 +623,7 @@ mips_target::low_remove_point (raw_bkpt_type type, CORE_ADDR addr, >> &priv->watch_mirror); >> >> /* Only update the threads of this process. */ >> - proc->for_each_thread (pid, update_watch_registers_callback); >> + proc->for_each_thread (update_watch_registers_callback); >> >> return 0; >> } > > Thanks for catching this. > > Approved-By: Simon Marchi Thanks; pushed. -- Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible https://sergiodj.net/