From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id aBUsLtdCz2eBVAsAWB0awg (envelope-from ) for ; Mon, 10 Mar 2025 15:51:51 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=ReyXkvml; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id B84F31E105; Mon, 10 Mar 2025 15:51:51 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=unavailable autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 6413B1E05C for ; Mon, 10 Mar 2025 15:51:51 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id F36D23858C31 for ; Mon, 10 Mar 2025 19:51:50 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org F36D23858C31 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=ReyXkvml Received: from omta040.useast.a.cloudfilter.net (omta040.useast.a.cloudfilter.net [44.202.169.39]) by sourceware.org (Postfix) with ESMTPS id 4811F3858D28 for ; Mon, 10 Mar 2025 19:51:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4811F3858D28 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 4811F3858D28 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.39 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1741636270; cv=none; b=uCfqytMWwNI9LyDNFHHXHSgqhA+nZHKTQFLY9TJHlTffS6APMSx9B/G2pai34b1gJSNg0pWB99W3qtW3kOYfqnr5bilYvvD2g5CsIZ/+RphluxsR014jWeLy+cmau1d7cpqvQpFKE9VgXkqH27qki+pBowN40WK6vMETTKjEq84= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1741636270; c=relaxed/simple; bh=0cn0Ayr0j4O8bIQM2ByDnQxt0+3VtGgxYT9JO/a44mE=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=tnGL1eWi7/y2wleEnI95dwk1mQIEUZqqNIRhqUlJ2B68QKa02eE07/9kc8BbMIXAXDfReEpOwd0brNBvvinDLRXisH6YUOZX4fUzTyY46ZIyI1jszMqrrAPYU8cdhG+NRbryM+YvbVYPYT0ifwgtdZiAty2WARUjjw1INX+gdvw= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4811F3858D28 Received: from eig-obgw-6010a.ext.cloudfilter.net ([10.0.30.248]) by cmsmtp with ESMTPS id rZvYtlkhAVkcRrj9Zt9ilE; Mon, 10 Mar 2025 19:51:10 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id rj9ZtmLvxZozcrj9Ztk2AW; Mon, 10 Mar 2025 19:51:09 +0000 X-Authority-Analysis: v=2.4 cv=GvNE+F1C c=1 sm=1 tr=0 ts=67cf42ad a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=Vs1iUdzkB0EA:10 a=ItBw4LHWJt0A:10 a=dzWzf_mpAAAA:8 a=hHEEfOeln2a2gcJYOLQA:9 a=b4DR9a7p2ZdsqdHBznES:22 a=6Ogn3jAGHLSNbaov7Orx:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=E1llMYCwYGU/ObJc/dWNkutlfjgDBcxhtX2GG4XgTOw=; b=ReyXkvmlT3N+F8NMzpellYTydC baUbirWGjUPpGtxwmqr6Z6LOxfoH8cGeEsTWB8TjfKMM2zXK4JlL7w55qN38Ec8dXcQ5raXYjIA8q QOEx6E6BuCT3RrPicr9sZ8KlO; Received: from 97-118-51-80.hlrn.qwest.net ([97.118.51.80]:36326 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.1) (envelope-from ) id 1trj9Y-00000002IVc-2RcB; Mon, 10 Mar 2025 13:51:08 -0600 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH v2] Add string cache and use it in cooked index In-Reply-To: <8c3b216e-5c62-42ce-8983-ef8e5df29bd5@simark.ca> (Simon Marchi's message of "Mon, 10 Mar 2025 15:45:56 -0400") References: <20250310193815.2425344-1-tom@tromey.com> <8c3b216e-5c62-42ce-8983-ef8e5df29bd5@simark.ca> X-Attribution: Tom Date: Mon, 10 Mar 2025 13:51:07 -0600 Message-ID: <87frjkslzo.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.118.51.80 X-Source-L: No X-Exim-ID: 1trj9Y-00000002IVc-2RcB X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-118-51-80.hlrn.qwest.net (murgatroyd) [97.118.51.80]:36326 X-Source-Auth: tom+tromey.com X-Email-Count: 8 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfI9m+HK9EgdzBJ0x8fzfAg3dTOf2jvoAAXz6zDjdbiOCjPr8SSDlYOmH5CEzsNE7GpFPEMMe3RYFbCPx7pS3JND0S2+gAkwjh5L8wDW1/6ERvp9p38wo dczs+dbjzi+otlGwPjzO6kS6xrXN+tcZs1MDd0q01LiiNc/U7mA3uuUyStp8fxPUI0gKV0BYi5nTeKkZLYk9YBOKdPMRieCc7nI= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Simon" == Simon Marchi writes: Simon> I was thinking that maybe this woud actually be a good use case for an Simon> obstack, since free'ing would probably be faster than freeing the Simon> strings individually. But we have cases where the caller passes a Simon> unique_xmalloc_ptr, in two cases we'd need an extra copy into the Simon> obstack. Yeah. Maybe it would still be better, I didn't try that approach. I tend to suspect the speed of scanning is more important than the speed of destroying the objects but I didn't measure it or anything. Anyway it's easily done if someone needs it. Tom