From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 3ye8H1X10md+UA4AWB0awg (envelope-from ) for ; Thu, 13 Mar 2025 11:10:13 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=R2mBSNOy; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 72A061E105; Thu, 13 Mar 2025 11:10:13 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id EE0001E08E for ; Thu, 13 Mar 2025 11:10:12 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 923DD3857C58 for ; Thu, 13 Mar 2025 15:10:12 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 923DD3857C58 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=R2mBSNOy Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id A2BB03858D33 for ; Thu, 13 Mar 2025 15:09:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A2BB03858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A2BB03858D33 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1741878581; cv=none; b=T4P5/+g8xIVAXgsmLcfgXuD1IOnuhACnID6pNwkSzR12Q2+HilROFera+10DzGWZcSKqbsI0QPWi3sLyXO9X/xXBAUsFlnyoyw2ze4d1shi5Wl0T4vGUsXQJpcxhP7uMptNq8IWnFXUfjPNG10VvYJKSQEijhuiZZaIAuWIE2Os= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1741878581; c=relaxed/simple; bh=gD96G9JVQfobGSWAbQDIYZrMiQ/hoks6+lj+Rfun9AY=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=tSzR8MEeeM6Z9Ar+iuiwI+EWyGMXAOwYn7qhCOsQU9+ByZW9SHiKxADeg9NGn7RkPxPpIGglWdRQMt5xuqObkjP+KMgIsoIKyesFYlV6StpeksLeFo2hqRKT18NRnhHhGSb2++Zv2OgERyy6bR+jHSgm1lv5EW83tewPcvYRlxw= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A2BB03858D33 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1741878581; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=NpgJdl5RgJ4UjWaOm9hKvMNr+SuthiQ/XS4F7yyWphM=; b=R2mBSNOyGKHC7Ky393h8Y+Yx5JW3UW8yk+z6vUVv3KCC4iMBe/oJVDHnxe1FgD+cvoUzfp ToZJJbp2Wm6IfD+EwXzoFGHJjZdG0j782fAOYg/z2ZAmpoodkKSuOx332Wty25ywwa9DJl xG3jmIXYV82Y2dq39f8Q+80I9B+BRsU= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-306-hkz_PUpqMLmT-YxATENHKQ-1; Thu, 13 Mar 2025 11:09:40 -0400 X-MC-Unique: hkz_PUpqMLmT-YxATENHKQ-1 X-Mimecast-MFC-AGG-ID: hkz_PUpqMLmT-YxATENHKQ_1741878579 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-39149cbc77dso619997f8f.3 for ; Thu, 13 Mar 2025 08:09:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741878578; x=1742483378; h=mime-version:message-id:date:references:in-reply-to:subject:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=NpgJdl5RgJ4UjWaOm9hKvMNr+SuthiQ/XS4F7yyWphM=; b=dVzrdrmXefXzg7FXmVzzpPP0IZPjcA/7Q/KAT4Yq7qlVo129favJo4zBV05+PL3w2J pmDbsFmwN5DbbXLbksZ4uJmK1DRikPRWWbLurIyxPynAsM82qvzlyVwX4mb8LYp+XvXx fckA9vx3wz0+T02Njo27hFSCT/b8uJt5lwHauKFOSKek18w3w61dBhQW+BOe9gLjI42M uHsGar0AXOBAq3RcXeoDnuzr+VdnnJZdlz+YdocAtrQkYTXPsTXO1OHNQwzUW/I9Eemv q2yjEwkIdFemypTZzMDIu/ZUkSH49IqP34+GT+OI1NWMYOFMYIIzLw+76uEi6GTj9rbo eSSQ== X-Forwarded-Encrypted: i=1; AJvYcCVMYiLBj+6v69/jj53xUiIT006WmgGXIe7B9ZjtD0r+YUWGudQ6t9V9QnHYRC87eKw1Xn5XN89xIP6zhQ==@sourceware.org X-Gm-Message-State: AOJu0YyTKPdmGhE3kWuW0cFOby5vmPylyd2eLcJWfwYX+zrXvs4boyNq FafywBg6TOFGb2IT2PslsyjLeMh6O0ON+4zsPDIkAYHROz+M8QIc5Jk3wVILYAwMYMY69SnjsJ9 dMNlh5kMIWg9v8PUvTCIPxA9YkyDaEUY8JBMmtvPcafGneZtoZx4roUHtuLNqkofANro= X-Gm-Gg: ASbGncvm9XOceCGqnIX58tgPt8aVbOsSBMd54IpWiszggHdDXxQlbSuoAxI/ibtwvL9 wRBtc+d/YeqI3T7dTBLP9tOnIwDAxA3WQNQNUhMcpyewVYB6UIy4SRxUdlrI0OU+b8DGAstPLVO TUnqxBNsFUnZ6SmH9pLAY4QLtnR4Mg1ZLZIS7V10p2uejnKHVhsfGz6nMU8hKmOpq+PV12BSKa/ jIWqY23S6Ecw/1r+2tfoGxArgvuDtPZXJB9XXB/P3ImaqLk3T1pxGwEUeFHKYB30QCkjW1iKzKk eQoDrXd1NFslEZnyHIUeSzSzKP80evp0yp0= X-Received: by 2002:a05:6000:2ac:b0:390:eb6f:46bf with SMTP id ffacd0b85a97d-39132d08dc1mr22921552f8f.5.1741878577700; Thu, 13 Mar 2025 08:09:37 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEBaQgFe2bGpvOTMoOFkC0r/F/zkoKSEzm1AmqCy11Bw/QQGdgISwqntoHfUoIMkc6T9tiDPg== X-Received: by 2002:a05:6000:2ac:b0:390:eb6f:46bf with SMTP id ffacd0b85a97d-39132d08dc1mr22921505f8f.5.1741878577145; Thu, 13 Mar 2025 08:09:37 -0700 (PDT) Received: from localhost (52.72.115.87.dyn.plus.net. [87.115.72.52]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-395c7df3537sm2443050f8f.8.2025.03.13.08.09.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Mar 2025 08:09:36 -0700 (PDT) From: Andrew Burgess To: Tom de Vries , gdb-patches@sourceware.org Subject: Re: [PATCH] [gdb/tdep] Backport i386_canonicalize_syscall rewrite to gdb-16-branch In-Reply-To: <20250313095325.23876-1-tdevries@suse.de> References: <20250313095325.23876-1-tdevries@suse.de> Date: Thu, 13 Mar 2025 15:09:36 +0000 Message-ID: <87frjhx8zz.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: ZmYeLZshNY4yqwa7z5qjaBGmM9Vw8Ka4XBqEl87juEg_1741878579 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Tom de Vries writes: > Commit fbfb29b304e ("[gdb/tdep] Rewrite i386_canonicalize_syscall") fixes > PR32770, which reproduces on the gdb-16-branch, but the commit is not ideal > for backporting because it completely rewrites i386_canonicalize_syscall. > > Instead, this is a version of the patch that adds a single line entry for each > syscall value for which i386_canonicalize_syscall gives a different result > with and without the patch. > > Consequently, the two versions give identical results. I've checked this for > syscalls 0 to 466. Given you've shown that this is equivalent to the version in fbfb29b304e, and having taken a look at that commit, I'd be just as happy to see that commit merged into the gdb-16-branch. The patch isn't small, but equally, it's pretty contained and straight forward, so I don't see huge risk there. But if you're happier with this approach in the gdb-16-branch, that's fine with me. Approved-By: Andrew Burgess Thanks, Andrew > > Tested on x86_64-linux with target board unix/-m32, on top of gdb-16-branch. > > PR tdep/32770 > Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=32770