From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id ZIUqJhgqK2iJLyoAWB0awg (envelope-from ) for ; Mon, 19 May 2025 08:54:48 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=bMoZlYde; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 822E61E11C; Mon, 19 May 2025 08:54:48 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-10.1 required=5.0 tests=ARC_SIGNED,ARC_VALID, BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED, RCVD_IN_VALIDITY_RPBL,RCVD_IN_VALIDITY_SAFE autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id DDF0A1E102 for ; Mon, 19 May 2025 08:54:47 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 5DB4E3858401 for ; Mon, 19 May 2025 12:54:47 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5DB4E3858401 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=bMoZlYde Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 5A16E3858D26 for ; Mon, 19 May 2025 12:54:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5A16E3858D26 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 5A16E3858D26 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1747659257; cv=none; b=r1NSdUGzFRWq6SCntiPr94dpsCYCHWDNw+FSinNIT2U1VIPN4k+4zE/eI1+7wlOyrgwha12SxewOp9zsyGkAlOPz11S+4m9TjZydhR3ti+eoJUq4+8POPRj7MP95FfO7IevTaJbv0s3VblKP05EOZDyETAZQqVFzLQEIZ+uacaM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1747659257; c=relaxed/simple; bh=hZFuRPJTkeFYGy028E0LHgrbrHoWfHstMQGg+oCMG0M=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=a2oBpFvlBiNUU2XXRKD0hBQEkeOtCDBJQPLh/2/LteDa47+FBx0/UiYW35ioFllLRuRrI0pwKv79CF6ZrvXHRcyQnribigX19yU59nJpBEqHx6r6YBTWynXD3XcKkVw6hTXlvPDSmY3Lc1+KnnnDiAkimhm/QhGTmVuBoHOx4mQ= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5A16E3858D26 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1747659257; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=M8qYsrk8YYKHx6F63ao9fFtain+WpJv18nF98UOjpTU=; b=bMoZlYdehxfLzOpNX6KWNT4NTAvI9PPDExNbQoCWW4/0KRsaV0zLHFAb1LTaKjqFp2kiov WZ2ig4SwBzFspB7lUCT7bdL3rgWIf5F8NR8wk6dZ50UctYJezjKWWg5vBM6na1H9+VG2Ta wOFVz7GMRGdZ/JvsUegTuvW8QPU4egk= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-390-5jBaKEZAPfun4WtOsbdCzQ-1; Mon, 19 May 2025 08:54:16 -0400 X-MC-Unique: 5jBaKEZAPfun4WtOsbdCzQ-1 X-Mimecast-MFC-AGG-ID: 5jBaKEZAPfun4WtOsbdCzQ_1747659255 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-3a3696a0d3aso616287f8f.2 for ; Mon, 19 May 2025 05:54:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747659254; x=1748264054; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=M8qYsrk8YYKHx6F63ao9fFtain+WpJv18nF98UOjpTU=; b=Z807uobDCp+sI4ylTw9l25YisXH0r/94Ugn+Cnz+Scdyj0J17BG+F5drKl+jJ9ZvZX x5r9q06uVIefktT6HhqYVX+hu5TMBL8Ou9MzzBxWUhHOGdhQ/rpovUqDuvJJRYMKXhvA 8ZXCId14Qt8B+UoPjVqxw4GxqNKxKl3kPOkSvK3da4F+Z3RwGuyStfsVIKS5n9j8nH8I GfD5BQVwxTdNceOLpEyGEnLCITt+cs3eOq+aOKl1ob9+px9+99+EAKgy/jEj7EI/GRQC pS7ErROYr60v/0rW1rxCw5QSCeTQSwCfl39ZXFKtKiFKGdBisa4JMJ6FCeGI1EWz2/r4 mmfw== X-Forwarded-Encrypted: i=1; AJvYcCWIGaZHm5PokIrqzxfJxNx+4NDkFxFr4OVBKtxYfQJCEWUSgnMGX4F1QlMYE6o1yyjyACteLhROv33GWA==@sourceware.org X-Gm-Message-State: AOJu0Yz2oxrjKZTLDNIfRKnMbdLgdrE+oC0c2nDoAUfHxZf985vDN+3L 9qdmEP7d8DlinfyV18YTq4KuLX+TxD4JJeePPoKLIMvSZ9o8jraxQSaqUHrO2v+YASZMnymiNGh HCW87l6PQXZSxt3Tm/4Rbt3Zot7otu3/USTSRNVogHFqGOIXbzi2QL+vC9zV45u5HTipxbGI= X-Gm-Gg: ASbGncuJE+RqniCM+erFGMPjwEVBNZl481cXavOhmLJfqr+hfbpxWRmKIt8zRVoPLCy UG8h0XtHkhyMrgaZiwOh7+Fo/6Ktol9G13P5OpRHlv4IxcOpgCFS5tC8spRr7L2JoB+uCnNCnDc RsbSpw8eh4yO93QSv+fnJz+zGdUJjtF1juKyZswKlwQvqq4TldutQkxahdWaEehteVPQeccWe2B 4097grEYH3A2/Sm7C+gBV28sQvvJpyeiUZaMq0UyoyfjGb6WBnnUOTQq6e6PtnWUTuYO/2rQTNO nr6h5Za2aU9p6Nqt67WEpPdSUoVad0E2EGpa X-Received: by 2002:a5d:494b:0:b0:3a3:4baa:3eba with SMTP id ffacd0b85a97d-3a35ffd28d6mr7033400f8f.47.1747659254125; Mon, 19 May 2025 05:54:14 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHZujzdX0EHqKi0a7/1hDItDDYIx5a0pHFemEQpNZaX2wcGvWUqGz1mrZ3EeoN0OCy1fVbypw== X-Received: by 2002:a5d:494b:0:b0:3a3:4baa:3eba with SMTP id ffacd0b85a97d-3a35ffd28d6mr7033390f8f.47.1747659253815; Mon, 19 May 2025 05:54:13 -0700 (PDT) Received: from localhost (30.226.159.143.dyn.plus.net. [143.159.226.30]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a35ca88735sm13020292f8f.69.2025.05.19.05.54.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 May 2025 05:54:13 -0700 (PDT) From: Andrew Burgess To: Tom Tromey Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 2/2] Allow check-mark to be changed for CLI In-Reply-To: <87wmag63jg.fsf@tromey.com> References: <20250509-emoji-check-mark-v1-0-63b6c52411f3@adacore.com> <20250509-emoji-check-mark-v1-2-63b6c52411f3@adacore.com> <87zfffnqrj.fsf@redhat.com> <87wmag63jg.fsf@tromey.com> Date: Mon, 19 May 2025 13:54:12 +0100 Message-ID: <87frh0n4ln.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: dHRxEu-9iUBhYWf3TcB_f4-HONNGGuCKLV6OujxIitk_1747659255 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Tom Tromey writes: >>>>>> "Andrew" == Andrew Burgess writes: > > Andrew> Tom Tromey writes: >>> In keeping with the emojification of gdb, this patch changes the >>> default "current" marker to be a check-mark. It adds a knob to allow >>> the character to be changed, and, as always, reverts to the old output >>> when emojis are disabled. > > Andrew> I haven't tested this patch just yet (short of time), but I wonder if I > Andrew> set the check-mark character to a multi-character string, does that > Andrew> corrupt the output? I'm guessing so as I don't think table columns > Andrew> auto-adjust. > > Andrew> So my real question: at a minimum, should the docs mention that the > Andrew> STRING should only be a single character. And better yet, can we check > Andrew> that the string is only a single character in width somewhere? > > Yeah, I will update the docs in v2. > > I don't think there's any way to figure out what the display width of a > string might be. At least, not unless gdb adds a dependency on > something like libicu. I did wonder if figuring out string length might be a challenge. I think just documenting the single character requirement is sufficient. Thanks, Andrew