From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id vSC8BalWzGiWggkAWB0awg (envelope-from ) for ; Thu, 18 Sep 2025 14:59:53 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=iiqOdRuq; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 008521E0BA; Thu, 18 Sep 2025 14:59:52 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_SBL,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=no autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 1291B1E04C for ; Thu, 18 Sep 2025 14:59:52 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 70E703858CDA for ; Thu, 18 Sep 2025 18:59:51 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 70E703858CDA Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=iiqOdRuq Received: from omta38.uswest2.a.cloudfilter.net (omta38.uswest2.a.cloudfilter.net [35.89.44.37]) by sourceware.org (Postfix) with ESMTPS id 689483858D35 for ; Thu, 18 Sep 2025 18:59:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 689483858D35 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 689483858D35 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.37 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1758221959; cv=none; b=ETcAjxzuEfmsVFouRisABv7YiG31eC9F+PiWgkRCB3/OX0ZHgJgiAtQ7vGymvz2AQ7q6RhQIoQsSqk+fZQ/3ysyDa5GaX8/y7UA0ubP8A/mwg/Vszb2U2tcixoelt8dYQMBkhMs/VeRvk0R9iylNRoXi//2kT2iYRnQYarHEdqs= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1758221959; c=relaxed/simple; bh=O8vEIv/uX7wxBq260H+nw8xp9bxgWsZ1l3qE4dImgVw=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=EFR8iXqKT/JdhCz15wv8rR6HHmnRYHrfSrRd6wMZDoN/2kziYzEBukaqohZlFilq/7zPwrI3LqwPuCh7PKavaslkiLI7E5S9CYHk7wVK/hCIrNexjq+XWWAVxkkBwB8mv3iMjzYJ8V38dTowDiT2Fnpx4XlKNqWxpoqYQkVyaCE= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 689483858D35 Received: from eig-obgw-6006b.ext.cloudfilter.net ([10.0.30.211]) by cmsmtp with ESMTPS id zHKOu7bXLeNqizJqgupgjx; Thu, 18 Sep 2025 18:59:18 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id zJqfuS1q7FQsKzJqfur4lJ; Thu, 18 Sep 2025 18:59:18 +0000 X-Authority-Analysis: v=2.4 cv=DrlW+H/+ c=1 sm=1 tr=0 ts=68cc5686 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=yJojWOMRYYMA:10 a=ItBw4LHWJt0A:10 a=_ZhYKdCeAAAA:8 a=zstS-IiYAAAA:8 a=v0GeD1Y4miqiJvQbxlkA:9 a=uqOk3ZSnBfCTOznnrPA1:22 a=4G6NA9xxw8l3yy4pmD5M:22 a=VS4QxaUSPT0UtbFnIvSC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Tr7DgLrvzkXKJ5HHmGzEt4uKD1mCpGeV5WGr+Osovzk=; b=iiqOdRuqQ/S6i1ONzZqeT1kWdl zvdf8Fzts2nr/woSSWks5i9mKAuC0jLnWi2WvTaxVIQtebwysd+6fGZ5MuHkDCCQ+Tomo64aeYEzl Sxw2s5OuF11IeqDG9VXhsvUbQ; Received: from 97-122-110-68.hlrn.qwest.net ([97.122.110.68]:51332 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.1) (envelope-from ) id 1uzJqf-00000002uZO-14Dy; Thu, 18 Sep 2025 12:59:17 -0600 From: Tom Tromey To: simon.marchi@polymtl.ca Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2 1/4] gdbsupport: use dynamic partitioning in gdb::parallel_for_each In-Reply-To: <20250703200130.4095761-1-simon.marchi@polymtl.ca> (simon marchi's message of "Thu, 3 Jul 2025 16:01:16 -0400") References: <20250703200130.4095761-1-simon.marchi@polymtl.ca> X-Attribution: Tom Date: Thu, 18 Sep 2025 12:59:16 -0600 Message-ID: <87frcjh9iz.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.110.68 X-Source-L: No X-Exim-ID: 1uzJqf-00000002uZO-14Dy X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-110-68.hlrn.qwest.net (bapiya) [97.122.110.68]:51332 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfE3f+vKHcmMgdTvRok+5+ZWmcPhXNRIhFdGVXjcZJ0hQ2/p6l3gzANcpi2TubrTSdOm7yOG+ZxzyHu4jyS6zl3kRzJP6NKgpjfDjKQ70B/ri4qTr2N9v NMyjBJuGmtazE71hLFbl7fJ13DUkhR5QBJl8a+ZEtrTLEmHMm+6CUqbXplhc9x4IKjJuBEvONf5+Ko4JUqj6ic05ew80oK05U+I= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Simon" == simon marchi writes: Simon> From: Simon Marchi Simon> gdb::parallel_for_each uses static partitioning of the workload, meaning Simon> that each worker thread receives a similar number of work items. Change Simon> it to use dynamic partitioning, where worker threads pull work items Simon> from a shared work queue when they need to. Finally getting back to this. Simon> Note that gdb::parallel_for_each is currently only used for processing Simon> minimal symbols in GDB. I am looking at improving the startup Simon> performance of GDB, where the minimal symbol process is one step. I do wonder if this functionality should just be intrinsic to thread-pool somehow, like separate the notions of a "task" and a "job queue". But anyway I think we should move forward with what exists. Simon> + auto task = Simon> + [&next, first, last, n_worker_threads, &args_tuple] () { I think the "{" should go on the next line. Approved-By: Tom Tromey Tom