From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id U8OQKBgs4Gh1Fx4AWB0awg (envelope-from ) for ; Fri, 03 Oct 2025 16:03:36 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=Z0UZuKKl; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 7E5A61E04C; Fri, 03 Oct 2025 16:03:36 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=0.2 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=no autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 0D1151E04C for ; Fri, 03 Oct 2025 16:03:36 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A8B053857B91 for ; Fri, 3 Oct 2025 20:03:35 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A8B053857B91 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=Z0UZuKKl Received: from omta040.useast.a.cloudfilter.net (omta040.useast.a.cloudfilter.net [44.202.169.39]) by sourceware.org (Postfix) with ESMTPS id 3EE8F3858D33 for ; Fri, 3 Oct 2025 20:03:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3EE8F3858D33 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 3EE8F3858D33 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.39 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1759521785; cv=none; b=MqYQsV4IoSePmR/4Xh/CaYuBcLBPi8Yf3JMSv4rcghFuptdBQkP7Dys0fuUiDs6Yhk0YkGTmpsp3EbUK6URCywLW1GS1Gb373FkVXcYvcnStengzQDgfR0ufJ/lHjnIYmg8u7eiWmN3YQ9l5ZdlXRMAqAphWd1oZf991YWomTPU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1759521785; c=relaxed/simple; bh=2hXpmUDFjtbN01k3QvZgGfy2XIqUOO6r+SIxH0PfY7w=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=heBu/aenH1DwFVSBWjDajbQ5O/B7XlgZHF/ik3v6fFoUw6sJDYZJ3z0BZBEBjn6v83bdhGtWYGIzOdyI6t0pF4PwiiOBVZxEswGCfolI559s0uXQj6IV9dnu/G+M9LL3WDA7LS1GRgDVDJpQ8H9Fl374YZpAO9lNFRW2xsZ4FPA= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3EE8F3858D33 Received: from eig-obgw-6001b.ext.cloudfilter.net ([10.0.30.143]) by cmsmtp with ESMTPS id 4QmyvhOLlv7244lzcvSElO; Fri, 03 Oct 2025 20:03:05 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id 4lzbvXqaTDV654lzcv5OwK; Fri, 03 Oct 2025 20:03:04 +0000 X-Authority-Analysis: v=2.4 cv=dLammPZb c=1 sm=1 tr=0 ts=68e02bf8 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=x6icFKpwvdMA:10 a=ItBw4LHWJt0A:10 a=QyXUC8HyAAAA:8 a=zstS-IiYAAAA:8 a=SKOXtV5y70KvE87BsYYA:9 a=4G6NA9xxw8l3yy4pmD5M:22 a=VS4QxaUSPT0UtbFnIvSC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=9Z9aZJ1QzKFUlkM79wSelFOqrokj3JtWGZhu37dq61I=; b=Z0UZuKKlqo+DRnvyfZM2DsU6DQ 5BYPduCMdvDtj2RfiS8IWUBMzSfVTjV/j1L/E707nKp6iBUSFuqswlTOd17ltRAbGRYeSOrdXARVd dXp4zWeZ6Na7A3SExJ2k8zzlg; Received: from 97-122-110-68.hlrn.qwest.net ([97.122.110.68]:39694 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.1) (envelope-from ) id 1v4lzb-000000012oP-20TY; Fri, 03 Oct 2025 14:03:03 -0600 From: Tom Tromey To: Christina Schimpe Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 5/9] gdb: Refactor 'stack.c:print_frame_info'. In-Reply-To: <20250923111842.4091694-6-christina.schimpe@intel.com> (Christina Schimpe's message of "Tue, 23 Sep 2025 11:18:38 +0000") References: <20250923111842.4091694-1-christina.schimpe@intel.com> <20250923111842.4091694-6-christina.schimpe@intel.com> X-Attribution: Tom Date: Fri, 03 Oct 2025 14:03:02 -0600 Message-ID: <87frbz69e1.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.110.68 X-Source-L: No X-Exim-ID: 1v4lzb-000000012oP-20TY X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-110-68.hlrn.qwest.net (bapiya) [97.122.110.68]:39694 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfN7blVMBIdnLOnRiQXjDBoo9j2e2A7qU9E3dnXy+ZJUdCfds+o750M+BDPGrO8uTuc7n3z7Rqi243fPp1WgGn/6Q0q+os2MZBM8aPTDuLWFOx89AryRZ FnU6zMSoQ/JcQeELi44u9J/Q5A+BkeDn2aYe7a8DLyNU5jqa+7N7XW/t+6qZBiPnlKk7u6E6WPhojZCf2wzZyrB8qk7ZvlCSbqE= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Christina" == Christina Schimpe writes: Christina> This patch restructures the 'stack.c:print_frame_info' function by Christina> introducing two new functions in stack.c. The new functions Christina> will also be called in a later patch "gdb: Implement 'bt shadow' Christina> subcommand to print the shadow stack backtrace." Looks good, thank you. Approved-By: Tom Tromey Tom