From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id KORkEKO72GnsJBAAWB0awg (envelope-from ) for ; Fri, 10 Apr 2026 04:58:11 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=gJEdL/CY; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 2630C1E0BC; Fri, 10 Apr 2026 04:58:11 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 8609A1E08C for ; Fri, 10 Apr 2026 04:58:10 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id C40394BA2E27 for ; Fri, 10 Apr 2026 08:58:08 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C40394BA2E27 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=gJEdL/CY Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id C284E4BA2E10 for ; Fri, 10 Apr 2026 08:57:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C284E4BA2E10 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C284E4BA2E10 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1775811463; cv=none; b=WEToS9eMVZkntg3e6Qrfc9vknmmdLUOpQ16zQSndBOTDSTp5D9qLwkbpl35noI1c8yZGlgsc7Jn9LvTVp50Ph7SQQpl870q3stsjOgZJq49QD+aWE6FsMVL+aeUduSwIzDD0hsedx6uiP6Mo2LEUrwsuMekw3C/3C43PHerl5Nw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1775811463; c=relaxed/simple; bh=vxlrhYITGppYrah78hJ0QrmJjja3HuX1/Hp9yE9ztdw=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=IFP+/vaByU8iEW7Y64926oHnVHul0NaP6GmQ8XRGLf/NiTMLXxZPVkxy2ATYz2D3fKwmEf/n4YwB2hDHFGae0ivjHyHCA9QmMHf+krjcuk1WonxwOTT5BgauRGng0han0pru1lphT434jmvZMjpaJ/hqRQ41Ag8kad6FJ0h5cts= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C284E4BA2E10 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1775811463; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Rz5hwh+LLW9HfxN48F4gpemgERkEOlg8Ip4ZwbwlOck=; b=gJEdL/CYL3kJINZcf6mp7ExKrVVMJrln3pUfWaSq1EWfP+zwyHXdUYEcVlb6prTa+Rl6jc lzPelARIgZp+U/TJOxWHyZrjRJqq6cWFI9wSVeA3s+6CaA4RMtG/rk38U9iVq87FfHd8KP 97e14euU7o3OkJ3sZ6sVytJZ7D7ll7s= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-399-QeRzt60qPReC2oWjDssa1w-1; Fri, 10 Apr 2026 04:57:42 -0400 X-MC-Unique: QeRzt60qPReC2oWjDssa1w-1 X-Mimecast-MFC-AGG-ID: QeRzt60qPReC2oWjDssa1w_1775811461 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-488c213b485so12803775e9.2 for ; Fri, 10 Apr 2026 01:57:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775811461; x=1776416261; h=mime-version:message-id:date:references:in-reply-to:subject:to:from :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Rz5hwh+LLW9HfxN48F4gpemgERkEOlg8Ip4ZwbwlOck=; b=gQmdGp7EPc+j1QNkO5aTQ3G15QpZGksgQRebSwCVVOE2uiTHq8Y7k67UN199/bkrC9 +V+iizHx4Tk5cxYfaiavYIcSDlESXlktC8ZaGjnmYvCF9fULA+ye38l/TVRhZKgxo6p5 QbBxgo/3zlTTx/L9IveGoIl/gzTP5sIXSGW9TZA40xdi57hKZauz2svsJpGvrnCC3tHJ f8GQsOFwrLBsyWraZE3xC4rysLGvOnKN36Bp0ZGmxJCMN1c7l8blYT+XnKQGnvZkvEkB OJmhD+q8vi3QHqHaTN94hmvfK4vf/cr1ytnr0935DMl4XYDjH+g1Ttp9SBxjYlPV+gJc OfRw== X-Forwarded-Encrypted: i=1; AJvYcCXrVrZK0p5g/1o8Fmg1APW9mhfRZAZPSlbJC04VtNBoeDYkecI81KOujkm3QDkMeN2WRL+qD1YivdFKow==@sourceware.org X-Gm-Message-State: AOJu0YxlMlNUUxcXUGb0xbcs7VGkeerDMe9YFHjIM6jpgfjsfR4vyfXJ FavVECSpFPkM3CiNRzVYtFMXClE+sW1X4ewD2NQ7py6ABcTWIB4DXqGI53MH5huPdVuJHN3bLH2 DvxgXgArboYDZxXQSAv3IaovBt4gFpD8m/R47doSQDXfzgXchoVTQaySrkUMPjKQ= X-Gm-Gg: AeBDiet1LqN+HcUySeOY7xRu1dJR+gatZt8vnuF29mclwLU+yh0Ez3kGSgJTQbtLZ6q qnIbuNyUjWa8/u58Xqf0Cva3nyD76vZRrGZgO3Paxoe9yIYJcNztTt8KHlSnr7DRweTPuJ09f7E Ej5bhUKx72ZAC/XxI5vXRYESunvBWdQ3xjETwFspVE8HyrIye+o5stB9ImtyZhHRZMUBHpSPy4z XOTSN64TE5BSFtGO5tdm0vMqddu3lRV2pfkF7ISSRFzFcCUamSN1og1T8yggapgPDUya2qrT04s kKHqcUXqM4IgloQA+WOKcMKUwmQ5tCveLsv2fXeJBthMo65nMcTJvaTqZYFMdQXOyfL1H5fpk6c UY+goBp3hSdHiwkW5 X-Received: by 2002:a05:600c:474c:b0:485:35d3:ce59 with SMTP id 5b1f17b1804b1-488d68101edmr26061765e9.10.1775811460684; Fri, 10 Apr 2026 01:57:40 -0700 (PDT) X-Received: by 2002:a05:600c:474c:b0:485:35d3:ce59 with SMTP id 5b1f17b1804b1-488d68101edmr26061385e9.10.1775811460142; Fri, 10 Apr 2026 01:57:40 -0700 (PDT) Received: from localhost ([31.111.84.232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488d66773c8sm32771005e9.0.2026.04.10.01.57.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Apr 2026 01:57:39 -0700 (PDT) From: Andrew Burgess To: Tom de Vries , gdb-patches@sourceware.org Subject: Re: [PATCH 1/2] gdb: use get_current_frame consistently in print_stop_location In-Reply-To: <4a5043ae-0554-4d09-b426-d42d5d66d972@suse.de> References: <20260331132342.1050954-1-tdevries@suse.de> <640943dbfd2e2d6555be950b04a4c50288e3334a.1775383137.git.aburgess@redhat.com> <337213ec-dce2-47d2-b04a-21aaf3d849dc@suse.de> <87o6js4ipn.fsf@redhat.com> <4a5043ae-0554-4d09-b426-d42d5d66d972@suse.de> Date: Fri, 10 Apr 2026 09:57:39 +0100 Message-ID: <87fr5342gs.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: paC0wYrtYtDqTQXzQewKOzS8iZNsBIBcg8DpBPhjI-o_1775811461 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Tom de Vries writes: > On 4/9/26 10:54 AM, Andrew Burgess wrote: >>> So I'm proposing a change to this patch (attached below, doesn't apply >>> to the first but to the second patch) that: >>> - introduces a variable print_frame >>> - assigns get_selected_frame (nullptr) to print_frame >>> - adds a comment explaining how print_frame relates to the stop frame >>> - uses print_frame everywhere in the function >>> >>> I tested the series in combination with the attached patch on >>> x86_64-linux, and found no regressions. >> Thanks for the great analysis, and explanation, I wasn't aware of this >> aspect of bpstat_print. Given this new information, I think your patch >> is the right solution. >> >> Approved-By: Andrew Burgess > > Hi Andrew, > > my initial idea here was that the patch I posted could be trivially > merged with the first patch, but upon attempting this I ended up > re-editing the series. I'm currently testing this, and will submit if > that goes ok. > > The content of the patch series should be what you posted plus > aforementioned patch, the changes I made are merely refactoring. The patch you posted applies on top of my patch #1, but I think it would be best if you just merged those two patches together. As you point out, my patch moves in the wrong direction. You're patch basically reverts mine and does something different, which is the right thing to do. Thanks, Andrew