From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 3K7rKfiG3mkCSRcAWB0awg (envelope-from ) for ; Tue, 14 Apr 2026 14:27:04 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=A2Mx7U7T; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 982811E0C3; Tue, 14 Apr 2026 14:27:04 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id E99441E04F for ; Tue, 14 Apr 2026 14:27:03 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 6D56B4BA2E08 for ; Tue, 14 Apr 2026 18:27:03 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6D56B4BA2E08 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=A2Mx7U7T Received: from omta40.uswest2.a.cloudfilter.net (omta40.uswest2.a.cloudfilter.net [35.89.44.39]) by sourceware.org (Postfix) with ESMTPS id B09F74BA2E07 for ; Tue, 14 Apr 2026 18:26:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B09F74BA2E07 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B09F74BA2E07 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.39 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776191194; cv=none; b=mdOzy8JeOcMFZrUSM0wguKsWIs0rOrjrefCj+kLvdElbNlWWxUfyTG1kdS0SvoAekUAvba4krC5bw+Fy3GLPvdMQS7kPLwAHDKjRGP8U3dU8l4MANw1/u6qXr7eFuDoR/QN8Kgf6aTtrO9mBcxIPfL1LF1wJFx54FhaHQZVtvak= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776191194; c=relaxed/simple; bh=oyNwQTxbjCJ96SQS2uN6CGyVCg4AE+K+HcmNablvmCU=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=Ni4JDEl6mqoyvnTCCka9GNzHtDobCPkl0gnhKIP0YCGa6NatjBMsGRXlX8N07qhHWizI+7ls/dxGaO9bcBdLTxU/pzw5TgcxQdMQCDXxHuDjOBXpKZygm1Xp/b2cmSG2SfYJtr945oedV6nEyD4rpxepj3kI06JnL7DYf4ofmoc= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B09F74BA2E07 Received: from eig-obgw-5007b.ext.cloudfilter.net ([10.0.29.167]) by cmsmtp with ESMTPS id CevgwevzDshqQCiT3wU9Wn; Tue, 14 Apr 2026 18:26:33 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id CiSswl73sxUZ2CiSswNQwX; Tue, 14 Apr 2026 18:26:22 +0000 X-Authority-Analysis: v=2.4 cv=HJHDFptv c=1 sm=1 tr=0 ts=69de86d9 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=A5OVakUREuEA:10 a=ItBw4LHWJt0A:10 a=TwjUyTvl9_z1a2eIZD8A:9 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=PXGuZqwP7jXh4EqSVOmM+F/HvtkHFXX5xGH1uxxVYOY=; b=A2Mx7U7TEb40OBffgrElrb0slW oFinM58gIII162qKbqLGf2JbEbp+FiVJwsrDahy12qDFR1mOinnai+6GgirXpsaeNGmCWSVamfhYC 3GihIPz6Gxqch3IZBeyMEl/MB; Received: from 75-166-225-82.hlrn.qwest.net ([75.166.225.82]:35504 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1wCiSs-00000002eFp-0WVe; Tue, 14 Apr 2026 12:26:22 -0600 From: Tom Tromey To: Tom de Vries Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v3 2/2] [gdb/exp] Fix ignoring of incorrect namespace prefix In-Reply-To: <20260410121144.1836026-3-tdevries@suse.de> (Tom de Vries's message of "Fri, 10 Apr 2026 14:11:44 +0200") References: <20260410121144.1836026-1-tdevries@suse.de> <20260410121144.1836026-3-tdevries@suse.de> X-Attribution: Tom Date: Tue, 14 Apr 2026 12:26:20 -0600 Message-ID: <87fr4xv1o3.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.225.82 X-Source-L: No X-Exim-ID: 1wCiSs-00000002eFp-0WVe X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-225-82.hlrn.qwest.net (bapiya) [75.166.225.82]:35504 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfB73TxnutAAWeBblJ81PSTbctNm1Qgxn+4rhcXnl844RzN5NePUKqh+0myej4CKrS/5fO+0gHi7zl3LKeDBPqbMyoizXbMbUUzMLOJCAgfpIIfSZ2ZwS 4Z9ubFlnpxjXO80Ofk7F5EU8GtOpaHdtlDysvpriPGgTsd+0HhaJbGfklctPsgjAKNK2vsxvnwKABl6rCrr114vIyJAzp/OEWyc= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Tom" == Tom de Vries writes: Tom> @@ -431,7 +431,14 @@ cp_lookup_symbol_via_imports (const char *scope, I find this function and related functions pretty hard to follow, so I'm not really sure about the bug or the patch, but: Tom> + const char *current_scope = (block->function () != nullptr Tom> + ? block->scope () Tom> + : nullptr /* Don't know. */); ... this line struck me as a bit weird, in that block->function() isn't set for all blocks inside a function, so this would mean that stepping into some nested block would seem to reproduce the bug again. Tom