From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 6UxUK9NC52maii8AWB0awg (envelope-from ) for ; Tue, 21 Apr 2026 05:26:43 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=hNjXTZ3B; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id AC8E41E0C3; Tue, 21 Apr 2026 05:26:43 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H2,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 21DCE1E067 for ; Tue, 21 Apr 2026 05:26:43 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 6F42B4BA2E3B for ; Tue, 21 Apr 2026 09:26:42 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6F42B4BA2E3B Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=hNjXTZ3B Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id A90E74BA5436 for ; Tue, 21 Apr 2026 09:26:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A90E74BA5436 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A90E74BA5436 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776763577; cv=none; b=G24o4PBmNFhzwwJ8YrD1QY05WVRK/fgLHnsMifLbXjS0LftHHWL5pWhDcbEe1ByLmxTLjO0VKlavpIH+YORwfQ1ejXfJLAxo/ezHdr8xkwAupcj4vT0ZVVyhDqpkq0epiPHAOL5uwKuOFp940icopg6i9uGI4kWpQIHxqNnwgx8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776763577; c=relaxed/simple; bh=h6bpLbk7WhR6iuJzmQn+xhb8Xf3CyTobL5MSdxJiWZY=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=T8tNbhN31iBuLXJYURyyC6uV31sU/TRurCkj0bJcyS2D4AJ5yZy/BL3eSVueDNH1b8DvHbakpl2de3t3VXg4ytUqqP+rPUDotUg9m9EoI0fKN+Ym33VRxmpC4x/AC7biQ+OdwaaP7mE/yGW7+EI44aMBx1QknmSChdtgNwsCZMI= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A90E74BA5436 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1776763577; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=z0317Qz54E69W1RGCb+WNHHTnD2mZzINNzPo7znwL0Q=; b=hNjXTZ3B5bQwqSe1RcTaQ+PVLyfuXZZrQhx0RUuFfpiYzUCaeh4yDpl9mr8xa1DzQHRy4A laoMc64dGRqkjZqQmUTBgRn+zPoHKeJhyKaRXLEqvEQjp0cw0VHc7ReD+SOrmR7IJoEQkT q4lBA3tsT9euQ7HK0XEsNsydIhEl60M= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-104-onT1eTe8PNuo5j6WDQpVgQ-1; Tue, 21 Apr 2026 05:26:15 -0400 X-MC-Unique: onT1eTe8PNuo5j6WDQpVgQ-1 X-Mimecast-MFC-AGG-ID: onT1eTe8PNuo5j6WDQpVgQ_1776763574 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-48919890a95so14527155e9.2 for ; Tue, 21 Apr 2026 02:26:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776763574; x=1777368374; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=z0317Qz54E69W1RGCb+WNHHTnD2mZzINNzPo7znwL0Q=; b=SBGhHAyU9E6+MnsNkRlJCGmzwXb1rNRPo0khDx0RECyD8ZCjzqEBtPc7DA5D85auk6 O43a4tQxggrO3QpU7/ttj8BQ7xjjNz9FN35su8qxLCo3pMFsQxeSGEQ2m+DQG2AV6j3m I3ORoslqPTtSEx7VG6s3z/foQfaa4ATNUQ4e5j839Tf4gadBTqXCI35mNAF4tbTZnE0O SwsARFVV1gyu+G213o5qJT+wOaFSP7zlNkMsI9rO1EqQMOqXpGDOXXtkRcfZql3lJexK IJ3hXmJr324QQWSgJ8FCd+UG07xu6VCM9j+gjUe4F1IseF9Qp1IKkV1gzYzsxJp0cJIA rxqQ== X-Forwarded-Encrypted: i=1; AFNElJ/d1mt1ANJv34pFq8gXYCMPqLQ0mYxx0DLzv7ZIO5kcDwiGs5SvFZlrlsXIoMU/OBs/1emCvfyQTXFYTg==@sourceware.org X-Gm-Message-State: AOJu0YxdLijGwMxORTxeCLfMjCAocMzK4oshty1EGB0MpYD+DXifZ3Kf LKPkqhu0oH4lZIx4sOi/vO2Vi8Sle2S7UWtqVaLLKNIgFAy/2nFoR0Sai/jesv96zqLxABPI0GG A9Xt3kbW4xz5mjiaqpF4nhrD0WfufLDzr0UHAhyt9Yo8zD0OZjAeOBKGCJrRZbmszpmagUR0= X-Gm-Gg: AeBDievwLcot4NOC3zAY0s8RJ2y41sowgv6XGYqTb48lX3u7o1hDrFEmt0V5tDpGml/ mmzjzn9oIIjQohiSRZrZHk5Fl2RuFMWLCM01YDv2fZcaaYBebPWT9HRNokXFqG4FH6XpbpVqSiQ uFv+cVv75oeLGltx7u4J2BmBg5Dck6eTFl1vT6RWbNvmonsOMKE79s17f7ibARbpXers26jIPdC dioXF3Nu4ALkphvvKrslSwN97p3oMsQ5W7nNlmS5IOKeFyWDJHD81nOI5zX60G/6XedfClPxcxt euS5qUl0P5nhxBa8Z41ecmMEwZ/WS4SwNOBQpYBVeAN3c5XEBCZ0bu9ysSC7AehtAoGm/RhBpPD xW1Bj8t7pxsIjFYy7pZ4TbkPRncI= X-Received: by 2002:a05:600c:1993:b0:489:e696:836f with SMTP id 5b1f17b1804b1-489e69686a7mr83614235e9.10.1776763574084; Tue, 21 Apr 2026 02:26:14 -0700 (PDT) X-Received: by 2002:a05:600c:1993:b0:489:e696:836f with SMTP id 5b1f17b1804b1-489e69686a7mr83613695e9.10.1776763573440; Tue, 21 Apr 2026 02:26:13 -0700 (PDT) Received: from localhost ([31.111.84.232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48a4b329542sm156941615e9.3.2026.04.21.02.26.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Apr 2026 02:26:13 -0700 (PDT) From: Andrew Burgess To: Simon Marchi , gdb-patches@sourceware.org Cc: Simon Marchi Subject: Re: [PATCH] gdb: add process_target_ops_ref In-Reply-To: <20260420183843.340801-1-simon.marchi@efficios.com> References: <20260420183843.340801-1-simon.marchi@efficios.com> Date: Tue, 21 Apr 2026 10:26:12 +0100 Message-ID: <87fr4o3brf.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: Rdyr5icye_AtmhZ_JpBxLvGM09MQwyw8Bh43__GmuHU_1776763574 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Simon Marchi writes: > This is just a more specifically typed version of target_ops_ref, which > avoids needing some as_process_stratum_target calls. LGTM. Approved-By: Andrew Burgess Thanks, Andrew > > Change-Id: I9d0d7954bebd3a8b947961752e4816fbced06eb5 > --- > gdb/infcmd.c | 5 +++-- > gdb/target.c | 8 +++----- > gdb/target.h | 4 +++- > 3 files changed, 9 insertions(+), 8 deletions(-) > > diff --git a/gdb/infcmd.c b/gdb/infcmd.c > index 4a907ea8ce86..f3f15c9ae1d0 100644 > --- a/gdb/infcmd.c > +++ b/gdb/infcmd.c > @@ -3042,7 +3042,8 @@ detach_command (const char *args, int from_tty) > detaching the parent. Otherwise detaching could close the > target. */ > inferior *inf = current_inferior (); > - auto target_ref = target_ops_ref::new_reference (inf->process_target ()); > + auto target_ref > + = process_target_ops_ref::new_reference (inf->process_target ()); > > /* Save this before detaching, since detaching may unpush the > process_stratum target. */ > @@ -3068,7 +3069,7 @@ detach_command (const char *args, int from_tty) > deprecated_detach_hook (); > > if (!was_non_stop_p) > - restart_after_all_stop_detach (as_process_stratum_target (target_ref.get ())); > + restart_after_all_stop_detach (target_ref.get ()); > > disable_commit_resumed.reset_and_commit (); > } > diff --git a/gdb/target.c b/gdb/target.c > index df2fe5cfd990..5d937f3ae858 100644 > --- a/gdb/target.c > +++ b/gdb/target.c > @@ -2562,14 +2562,12 @@ target_detach (inferior *inf, int from_tty) > > /* Hold a strong reference because detaching may unpush the > target. */ > - auto proc_target_ref = target_ops_ref::new_reference (inf->process_target ()); > + auto proc_target_ref > + = process_target_ops_ref::new_reference (inf->process_target ()); > > current_inferior ()->top_target ()->detach (inf, from_tty); > > - process_stratum_target *proc_target > - = as_process_stratum_target (proc_target_ref.get ()); > - > - registers_changed_ptid (proc_target, save_pid_ptid); > + registers_changed_ptid (proc_target_ref.get (), save_pid_ptid); > > /* We have to ensure we have no frame cache left. Normally, > registers_changed_ptid (save_pid_ptid) calls reinit_frame_cache when > diff --git a/gdb/target.h b/gdb/target.h > index 9fb29be01b69..81726849d1e7 100644 > --- a/gdb/target.h > +++ b/gdb/target.h > @@ -1442,7 +1442,9 @@ struct target_ops_ref_policy > }; > > /* A gdb::ref_ptr pointer to a target_ops. */ > -typedef gdb::ref_ptr target_ops_ref; > +using target_ops_ref = gdb::ref_ptr; > +using process_target_ops_ref > + = gdb::ref_ptr; > > /* Native target backends call this once at initialization time to > inform the core about which is the target that can respond to "run" > > base-commit: 9b9cbb09d85e40adb9a22f3c97de74b6c9c5e205 > -- > 2.53.0