Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Pedro Alves <pedro@palves.net>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Windows gdb: all-stop, interrupt with "stopped" instead of SIGTRAP
Date: Tue, 05 May 2026 08:17:27 -0600	[thread overview]
Message-ID: <87fr46eya0.fsf@tromey.com> (raw)
In-Reply-To: <20260505122434.1444507-1-pedro@palves.net> (Pedro Alves's message of "Tue, 5 May 2026 13:24:33 +0100")

>>>>> "Pedro" == Pedro Alves <pedro@palves.net> writes:

Pedro> Currently, "interrupt" uses DebugBreakProcess (or equivalent), which
Pedro> injects a new thread in the inferior that executes an int3 instruction
Pedro> (on x86), which raises a SIGTRAP.  With the target backend in non-stop
Pedro> mode, its easy to avoid all that and make interrupt in all-stop just
Pedro> suspend a pre-existing thread and report "stopped", like "set non-stop
Pedro> on" does (via target_stop).

Looks reasonable to me, thanks.
Approved-By: Tom Tromey <tom@tromey.com>

Pedro> +void
Pedro> +windows_nat_target::stop (ptid_t ptid)
Pedro> +{
Pedro> +  stop_interrupt (ptid, false);
Pedro> +}

I guess this didn't land:

https://sourceware.org/pipermail/gdb-patches/2026-April/226456.html

but OTOH I think your implementation is more precise.

thanks,
Tom

  reply	other threads:[~2026-05-05 14:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-05 12:24 Pedro Alves
2026-05-05 14:17 ` Tom Tromey [this message]
2026-05-07 18:44   ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fr46eya0.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=gdb-patches@sourceware.org \
    --cc=pedro@palves.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox