From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id EeJIFVZjCGqevT8AWB0awg (envelope-from ) for ; Sat, 16 May 2026 08:30:14 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=OtR156oH; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 52C291E093; Sat, 16 May 2026 08:30:14 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id DEAE01E093 for ; Sat, 16 May 2026 08:30:13 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 117BE4BABF3C for ; Sat, 16 May 2026 12:30:13 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 117BE4BABF3C Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=OtR156oH Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id E77174BABF35 for ; Sat, 16 May 2026 12:29:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E77174BABF35 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E77174BABF35 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1778934588; cv=none; b=eFdqTwVawdaQ1KF3FEZM5m3bkX52g6dc0/HdD1PqyU2/Z3LQvqHa/z3lfDTny59EbYISqhThsbmYVAdEZ4V1yh2rKV9JiBpcxhTQeXrK+Rs3qpY/aKaMlxuwyJW+tTF8AHjYrAwmmWV8KbsX4lDQp1QXs8KY/xSYTbliRI8lvl0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1778934588; c=relaxed/simple; bh=iso9aUUyMthxolwM22Nesiv7Mjxi6DMR6//70upIyLA=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=HSKLkGo4a0xVH7G8MYeW3Ry97lUrywSjH2LFro1WtT0SlJf3K2oilCT1DIFoZMVLPVeRTS2qiU7BbAVUUkwty2LuyImfPzNPDrdCEgtUCaYMF7YZ9so6h16mMqkzQJjrP7NL6ERhh/P9HIUXgCtDgSf1E3OsLoH3rgL3+unJkgM= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=OtR156oH DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E77174BABF35 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1778934587; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=oRf55Tjg5DtWwS/+LBQKvtPp9BCK8F5bIQUfGrdyzl8=; b=OtR156oHNr5QBgdU6NyHINuyHh1Wc0hN/jUWob+nafxGjGJfaBKFHizLrfd50yndHPKd1F c7+ER6oFD3Yt4XAc9t/bHKjsPJpVumY/mJmhtA0ZEWeT8/svoUzpbfUYQu8LasMqU5by4r NzDvSpGGaghSxJDapr3iohCuCHns/7U= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-649-slh_lrzDNKy4pjKaB9zJ_Q-1; Sat, 16 May 2026 08:29:46 -0400 X-MC-Unique: slh_lrzDNKy4pjKaB9zJ_Q-1 X-Mimecast-MFC-AGG-ID: slh_lrzDNKy4pjKaB9zJ_Q_1778934585 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-45e55c44ac1so483612f8f.0 for ; Sat, 16 May 2026 05:29:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778934584; x=1779539384; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=oRf55Tjg5DtWwS/+LBQKvtPp9BCK8F5bIQUfGrdyzl8=; b=UV0hh3jbEErFfXi0cX1dCwDObIGy2GlrW5Y1j8QaQoxnaRTZfOMw43SO3wqeYt+W/h MF/CSkx7Gp/dJ8fGV8ExKZUnTTk3bgogeBkTbG8b1fYQRSsR123GCEEPUBbq9DJxd1Gc d40803DPzTYdx1axdK64mp3OBc5sypcEePhO5YQVc7sMn/XAFC7yK3cHkiS1GrUEFMOf gwkdNP5YiZ0NGU8QGxHNv5Q7wy6/FEqo34zB6hJdmTblyM3KQ6t+CRVXAsCBVR0k17kR 7IMVc27MIXXi7MzJOtdB5RWkLR+wK3CM+tTNxYVmmmWxBh75NUdvxb/2ts/5Iw/I9QQQ 9Csw== X-Gm-Message-State: AOJu0YzsmN20W+JRI4P46a/67lDN0ZRKnTpn6hG/OxBGVtHGREivKgwB nCwgnmSy6zpjne9mztimVzvuDRSMyrxEUvMIiZ4QZ5HtOG/MbBw2k81k7lII/K7XTGGOQvKWThc +hFXs2XJj4acFGHar/D0uEpJ8KXI26jle7iut7EciDK4UfwiNZujWm10xn/F5hzeXPH+yH2c= X-Gm-Gg: Acq92OEPvOTwCoYSRBKj1GQ6D+/BZ1OEPpQBmLYMjbQuumKUfAeDeH2QRhpHbN939+o 7rwWvdCL2cHLi8jMd9ShbPJFuru1bBlzUnTU8hs+JBni1zhNyNI+03w5P51pKWPljiAu5w06slN RnMxi+5AWTQlagqY6WAsanKZrVZQ2uL2WCOPKNPOuVSM70t/5RMO2B5Zu06oAdDtULn47eI2uFH i48md1PhvB4IXuimKSUqI2k34UXfyqdam71GmArXF0bHU4DXX0X7f9PctYKLBy0GF7TqWQlOhsO dOiSpnOKaRksxSdUuklWGoKNP+l6eKENOFl7i6+jtuyC+YPg0tLhtcJVH0o92ZUZtVzt0cWCH7p +Nacv1QAKhsJU/FGaWA== X-Received: by 2002:a05:600c:34cf:b0:48e:5990:9698 with SMTP id 5b1f17b1804b1-48fe651588fmr115073675e9.24.1778934584540; Sat, 16 May 2026 05:29:44 -0700 (PDT) X-Received: by 2002:a05:600c:34cf:b0:48e:5990:9698 with SMTP id 5b1f17b1804b1-48fe651588fmr115073335e9.24.1778934584118; Sat, 16 May 2026 05:29:44 -0700 (PDT) Received: from localhost ([109.144.20.165]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48fe4c833fcsm123346705e9.2.2026.05.16.05.29.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 16 May 2026 05:29:43 -0700 (PDT) From: Andrew Burgess To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 3/3] gdb/testsuite: add a test to check for Python traits static_assert In-Reply-To: <87lddkh952.fsf@tromey.com> References: <93b625c0ab2f23cafa636d42e503361b70ee6edf.1778839043.git.aburgess@redhat.com> <87lddkh952.fsf@tromey.com> Date: Sat, 16 May 2026 13:29:42 +0100 Message-ID: <87fr3rczbd.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: HsEM1VfurSoRQnHNXp68DW11t4dFCqn4U4z5H7-JbFc_1778934585 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Tom Tromey writes: >>>>>> "Andrew" == Andrew Burgess writes: > > Andrew> The previous two commits added a new type trait which can be used > Andrew> within a static_assert to check the properties of a struct used by GDB > Andrew> to implement Python objects. > > Andrew> The previous commit fixed a bug in GDB which this trait check exposed. > > Andrew> This commit adds a new test gdb.gdb/python-traits-check.exp which > Andrew> checks that every struct in the Python/ directory that inherits from > Andrew> PyObject, has a suitable static_assert in place. > > Andrew> Adding this test should mean that if someone adds a new Python object > Andrew> type to GDB, and they forget to add the static_assert, then this test > Andrew> should give a failure, which should remind them to add the required > Andrew> static_assert. The static_assert will then check that their new > Andrew> struct is compliant. > > With the "safety" work we can have the compiler check this; or if the > tp_init plan works out, I guess just drop the requirement entirely. ACK. As with patch #1, once there's a better way, and the static_asserts are no longer of value, I'm happy for this patch to be reverted. But for now, while it adds some value, I've gone ahead and checked it in. Thanks for reviewing this series, Andrew > > Approved-By: Tom Tromey > > Tom