From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id mVVoIvsVD2onxgwAWB0awg (envelope-from ) for ; Thu, 21 May 2026 10:26:03 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=bcyOgXYh; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 80E671E024; Thu, 21 May 2026 10:26:03 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id EA4701E024 for ; Thu, 21 May 2026 10:26:02 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A2BD14C900DD for ; Thu, 21 May 2026 14:26:01 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A2BD14C900DD Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=bcyOgXYh Received: from omta40.uswest2.a.cloudfilter.net (omta40.uswest2.a.cloudfilter.net [35.89.44.39]) by sourceware.org (Postfix) with ESMTPS id E4EBE49B0BA7 for ; Thu, 21 May 2026 14:25:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E4EBE49B0BA7 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E4EBE49B0BA7 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=35.89.44.39 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1779373537; cv=none; b=Z9K7+DWT/Gjm7xCn3mLXPSoRHMQhrrHCKI+gkkVu5kmVEl7030xAbwR7rjKTI30NYQ9Bp7Y6Qelznwya8zvaZLCsag4dQrk6nn1OTitDsAi1ilbXaDdi/BvUNVl0r3tVsm2C68IaF6USKOW5PLrJ/ETi7yhrOafJbkaATgrQk1I= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1779373537; c=relaxed/simple; bh=oRyRZoWcps9kDNu1K89ZmICfV8cTdWtJWAXrui/PaEo=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=eOfNyUE1I5BI+/f5hwHd0LvBpGfRrPKsGzivfHA1UMH5ZBaSYi81c3hWa4AkUtx9R+t185ZcjQqB6OdHn2fARfIoqrBrYJbXdzEGjw6I+znUvhz6nBIHDv8Ysy3wP8tFIW8XyAoBWn+YJPzToABqKbnnlAwViYsBb67ZDqFsijw= ARC-Authentication-Results: i=1; sourceware.org; dkim=policy (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=bcyOgXYh reason="signing key too small" DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E4EBE49B0BA7 Received: from eig-obgw-5004b.ext.cloudfilter.net ([10.0.29.208]) by cmsmtp with ESMTPS id Q2yiwPRfKjgweQ4L9wcI8u; Thu, 21 May 2026 14:25:36 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id Q4L8wyMQfnfJUQ4L9wtudq; Thu, 21 May 2026 14:25:35 +0000 X-Authority-Analysis: v=2.4 cv=KajSsRYD c=1 sm=1 tr=0 ts=6a0f15df a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=NGcC8JguVDcA:10 a=ItBw4LHWJt0A:10 a=_ZhYKdCeAAAA:8 a=zstS-IiYAAAA:8 a=zuWzMssHAfSo-IBWwaUA:9 a=zgiPjhLxNE0A:10 a=uqOk3ZSnBfCTOznnrPA1:22 a=4G6NA9xxw8l3yy4pmD5M:22 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=GOf23pfj+7GQh0n8g0KPIWDtSMyuCIbgerQay1mhexU=; b=bcyOgXYhiivZxIJ1BCq8LoaSUk CGWWcoMY2zpMXBNd/H+6Mry8/HVJmHTpXg2XSwIIPsfZ3diJRWWWIww5W0ShFV4VlKXJUVj1Np4gT 1AwzyeCs5AwTpYcHmw1kvdYWI; Received: from 75-166-225-82.hlrn.qwest.net ([75.166.225.82]:58786 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.99.2) (envelope-from ) id 1wQ4L8-00000002M8Z-2TKt; Thu, 21 May 2026 08:25:34 -0600 From: Tom Tromey To: simon.marchi@polymtl.ca Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 2/2] gdb/dwarf: track whether the all_units vector is sorted In-Reply-To: <20260520182101.4074675-2-simon.marchi@polymtl.ca> (simon marchi's message of "Wed, 20 May 2026 14:19:29 -0400") References: <20260520182101.4074675-1-simon.marchi@polymtl.ca> <20260520182101.4074675-2-simon.marchi@polymtl.ca> X-Attribution: Tom Date: Thu, 21 May 2026 08:25:33 -0600 Message-ID: <87fr3kalgi.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.225.82 X-Source-L: No X-Exim-ID: 1wQ4L8-00000002M8Z-2TKt X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-225-82.hlrn.qwest.net (bapiya) [75.166.225.82]:58786 X-Source-Auth: tom+tromey.com X-Email-Count: 8 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfO5VO+hYy2QLHQQiXZ1OqZ21VPDiVJAkAEV8M3Xy7JzgUsMjG3NWIUsUExkFgTjN50a+Eqv0ZM0y1jqInIlaplh/gP5dr+czb4Jkol2aKA+bItz61lQQ cu96/rGhL6m7JREQLp0SDaxz5tWuZpPafT6NlU146gCcPjVD7x+zaBF70AgZ02f5sRLc476TiV4zuzt+VlM2Txh302fWnsRtzHk= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Simon" == simon marchi writes: Simon> Note that the flag is cleared when appending a unit even if the vector Simon> would by chance already be sorted. This is good, because it will catch Simon> mistakes even on machines where a problem with std::lower_bound would Simon> not manifest. Simon> I checked that this patch would have caught the problem before commit Simon> fbaef7de7701: Simon> (gdb) file /home/simark/build/binutils-gdb/gdb/testsuite/outputs/gdb.dwarf2/debug-names-bad-cu-index/debug-names-bad-cu-index Simon> Reading symbols from /home/simark/build/binutils-gdb/gdb/testsuite/outputs/gdb.dwarf2/debug-names-bad-cu-index/debug-names-bad-cu-index... Simon> /home/simark/src/binutils-gdb/gdb/dwarf2/read.c:18092: internal-error: dwarf2_find_unit: Assertion `per_bfd->all_units_sorted' failed. Thanks, and especially for checking this. Approved-By: Tom Tromey Tom