From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id Kbc+N/iW0WrjYRYAWB0awg (envelope-from ) for ; Thu, 15 Oct 2026 23:16:08 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=W6M8j6QW; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id D92D61E047; Thu, 15 Oct 2026 23:16:08 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 8A0F91E047 for ; Thu, 15 Oct 2026 23:16:06 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 8A2024BA23D8 for ; Fri, 16 Oct 2026 03:16:05 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8A2024BA23D8 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=W6M8j6QW Received: from omta36.uswest2.a.cloudfilter.net (omta36.uswest2.a.cloudfilter.net [35.89.44.35]) by sourceware.org (Postfix) with ESMTPS id E3AC94BA2E15 for ; Fri, 16 Oct 2026 03:15:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E3AC94BA2E15 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E3AC94BA2E15 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=35.89.44.35 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1792120540; cv=none; b=Lxm85m3htJjPuNT0J+mzlxS0+VurvgZOl9TdqBydDkTQm1PUI09D2RVKa3eU6xWaYHARiITbDhxiEIon9eWQRsM71jc0vGqv0bve8ReKf5QKxkcS4t5jO90CJCeQUDU+eKTZC3WmfrNma4LvwclpMEEdUc1EJA0CoLjDepADhQk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1792120540; c=relaxed/simple; bh=qQpsDL5wJ0xYZvtIgm+HV6UVgrAu7bmJpa2nSs2c91Y=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=jLVr9CJZaQr6xqfU6sPL0DdoLwNevpLgaRP0v0iBlkoJpZU2pqDR/wTlLnJAs3TJeg9kMK24gmePACY+UYNVBQwfWD7Hi7jdv5aYNqnMKbb7qe8HNZ3RZ8ksu3h/yjYZcikCb18oh0gRvC7kZp46UvyHc4LrQCoaVUbIV6sDx/E= ARC-Authentication-Results: i=1; sourceware.org; dkim=policy (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=W6M8j6QW reason="signing key too small" DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E3AC94BA2E15 Received: from eig-obgw-6002b.ext.cloudfilter.net ([10.0.30.203]) by cmsmtp with ESMTPS id HTLdx2aXKusRSHYPnxYkEk; Fri, 16 Oct 2026 03:15:27 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id HYPmxa3lXRC6eHYPnxah5c; Fri, 16 Oct 2026 03:15:27 +0000 X-Authority-Analysis: v=2.4 cv=FvsF/3rq c=1 sm=1 tr=0 ts=6ad196cf a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=660iZSQnnn4A:10 a=ItBw4LHWJt0A:10 a=5DlfPqgMnZgrisjHOXIA:9 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Unsubscribe-Post: List-Subscribe:List-Post:List-Owner:List-Archive; bh=nBGBhiNP8MJMtyHG10e9OLPeIIg+zBwzDa+kGzVhXoM=; b=W6M8j6QWd6W7ryKhafapg/zFfx Guz9xPdsfxDtW9Bz6n/e5RaUW2x6Z1RtM5HdFEhU3wwoHN9IDvevfD4UuHH2bxIwfeyegZN63Y21B e7nxttaPmJOyS31UBWYw3jGek; Received: from 97-122-110-129.hlrn.qwest.net ([97.122.110.129]:45816 helo=prentzel) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.100.1) (envelope-from ) id 1xHYPm-00000002nSE-1RLK; Thu, 15 Oct 2026 21:15:26 -0600 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , Simon Marchi , gcc-patches@sourceware.org, gdb-patches@sourceware.org Subject: Re: [PATCH v2 1/2] gdb: add selftests for split_name In-Reply-To: (Simon Marchi's message of "Thu, 15 Oct 2026 14:33:55 -0400") References: <20261005052602.1288766-3-simon.marchi@polymtl.ca> <20261014164830.358677-2-simon.marchi@efficios.com> <878q3z2cd7.fsf@tromey.com> X-Attribution: Tom Date: Thu, 15 Oct 2026 21:15:24 -0600 Message-ID: <87fqy6gwtv.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.110.129 X-Source-L: No X-Exim-ID: 1xHYPm-00000002nSE-1RLK X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-110-129.hlrn.qwest.net (prentzel) [97.122.110.129]:45816 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfD0pzH3Wipr2uhiYUpQ8m1qyL9VP8CdkpLwzjr+diKYJ5vDiGxkyoW/J2GdNYbj+heNYfiWytjLqYKYm7UGgZyVjKkqG9XbmcdOrmniSqtkoEddjf/7B CcoALeZODDtN43SnXmx9UYe2KTWgUH5PknjRAuvWXFHwvV8dMru/VFrMHVfqovLJIBOIYVrfmHYi94Z2o6G/txKOD0pcXH8/FY0= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >> I've often regretted not adding a SELF_CHECK variant that takes two >> arguments, and then prints them both when the comparison fails. Simon> It's funny that you say that because yesterday I was thinking how our Simon> SELF_CHECK macro could do like catch2's CHECK/REQUIRE macro and automatically do Simon> that. I don't know if you have used catch2 before, but the output of a Simon> failing test is: I haven't used it but yeah, something like that would be good. Though IIUC check2 uses some hairy stuff to dissect the expression, not sure if we really need all that. Most of the time I think we're just comparing == or !=, or anyway just handling those would be a step forward. Tom