From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 6WFTNSsm2WqIqggAWB0awg (envelope-from ) for ; Wed, 21 Oct 2026 16:52:59 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=hb7hr4UB; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id D6A221E04D; Wed, 21 Oct 2026 16:52:59 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 42D9F1E04D for ; Wed, 21 Oct 2026 16:52:59 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id CA9624BA2E0F for ; Wed, 21 Oct 2026 20:52:58 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org CA9624BA2E0F Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=hb7hr4UB Received: from omta040.useast.a.cloudfilter.net (omta040.useast.a.cloudfilter.net [44.202.169.39]) by sourceware.org (Postfix) with ESMTPS id 4B8F14BA2E0F for ; Wed, 21 Oct 2026 20:52:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4B8F14BA2E0F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 4B8F14BA2E0F Authentication-Results: sourceware.org; arc=none smtp.remote-ip=44.202.169.39 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1792615954; cv=none; b=OZQxxNdXhDRJ4O2OyYHbCFpq6od3qYmiy3zaLoONlnIf7aOv231RKYRf5i4ykEWqsDaKopaBMysBZvJM5dw7YDxqONDbFvgjI56u22im/bnPz6RgF/evPAT548dXJ5KLDq4DokFsYibY2x0xue4ehBMSqenZ/QBBt+hbv8EOhN8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1792615954; c=relaxed/simple; bh=CGt1BZs5d5RzylAETn0IJ18bav3zIkfxsvbrBG0PZ10=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=SYQRuG2+1F38V3mDcwIPvL1aUvhzfJP5A1HMbXV/SImdTQRdOh52E09WW2jhyOKhE5YPpwMZU7gxVSLmlH/gJKHNdiLHERBZgA3Yr0gKVxxdALEbJPBzB1fN+yiTuMZXpNeJ8ZD+Nt8bj4qooWLC4nr2nleJgW2/8z41dVB/dwY= ARC-Authentication-Results: i=1; sourceware.org; dkim=policy (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=hb7hr4UB reason="signing key too small" DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4B8F14BA2E0F Received: from eig-obgw-5004b.ext.cloudfilter.net ([10.0.29.208]) by cmsmtp with ESMTPS id JbXfxXjegMylkJdIYxQnLB; Wed, 21 Oct 2026 20:52:34 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id JdIWxHpBlirxPJdIWxu8Go; Wed, 21 Oct 2026 20:52:33 +0000 X-Authority-Analysis: v=2.4 cv=FqoF/3rq c=1 sm=1 tr=0 ts=6ad92611 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=660iZSQnnn4A:10 a=ItBw4LHWJt0A:10 a=QyXUC8HyAAAA:8 a=laxrTEGzem_he-GKsuYA:9 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Unsubscribe-Post: List-Subscribe:List-Post:List-Owner:List-Archive; bh=UDDHwvbLbg681kdbJsc8sfSqWjlUpVoNlJe1P8lK0uk=; b=hb7hr4UBSvnXd0eJr1OwCKYrpG 0dC2CCM6ENciu0wA3vEBaZ2PBxABt0PWePYIQrteF8qDEu1FLM6wMt5afBbMvvL+L0jjNPJem7WCI GKAuxX0iWakcF1dVHbPjDt54P; Received: from 97-122-110-129.hlrn.qwest.net ([97.122.110.129]:40184 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.100.1) (envelope-from ) id 1xJdIW-00000003NZG-0mAF; Wed, 21 Oct 2026 14:52:32 -0600 From: Tom Tromey To: Abdul Basit Ijaz Cc: gdb-patches@sourceware.org, JiniSusan.George@amd.com, tom@tromey.com, eliz@gnu.org Subject: Re: [PATCH v11 05/10] gdb: Skip trampoline functions for the finish and reverse-finish commands. In-Reply-To: <20260803193449.33375-6-abdul.b.ijaz@intel.com> (Abdul Basit Ijaz's message of "Mon, 3 Aug 2026 21:34:44 +0200") References: <20260803193449.33375-1-abdul.b.ijaz@intel.com> <20260803193449.33375-6-abdul.b.ijaz@intel.com> X-Attribution: Tom Date: Wed, 21 Oct 2026 14:52:31 -0600 Message-ID: <87fqxyu67k.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.110.129 X-Source-L: No X-Exim-ID: 1xJdIW-00000003NZG-0mAF X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-110-129.hlrn.qwest.net (bapiya) [97.122.110.129]:40184 X-Source-Auth: tom+tromey.com X-Email-Count: 21 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfLsiphQijIaXHsu2rcDsRZyrRmtIqhOXy0DPqYj/zmSDkBvs4orVcqRWdTPcN0RNOFd5q8GmAPuGJ4EsOeiiw2moWVsSZjeFIn4JgwxCLalQEAZc6spv BI2rDKZvgl1fRy5r15Al9N7CQwHK20+kDkWIm45ZvM9MhVB1j221QSBasXAqpWCy+002tRU7lKL0mZZBF0T4oT6vo3jwkrhoU1Y= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> Abdul Basit Ijaz writes: > This change skips trampoline functions when the option > 'skip-trampoline-functions' is set to 'on' for the finish or reverse-finish > command. Before this change, for these commands GDB returns to the trampoline > function indicated by the compiler with DIE "DW_AT_trampoline". For better > user experience, all such frames can be hidden from the user. Ah, ok. I was looking at the patches mostly in order, so I missed that there was a separate patch for "finish". > + for (int i = 0; (SAFE_TRAMPOLINE_CHAIN (i, frame) > + && in_trampoline_frame (frame)); ++i) > + frame = get_prev_frame (frame); This snippet appears in several places and I think it would be better as a function. Then maybe the SAFE_TRAMPOLINE_CHAIN macro could be dispensed with as well. Tom