From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-87833-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 24242 invoked by alias); 10 Feb 2012 17:30:55 -0000
Received: (qmail 24232 invoked by uid 22791); 10 Feb 2012 17:30:54 -0000
X-SWARE-Spam-Status: No, hits=-7.0 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 10 Feb 2012 17:30:37 +0000
Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q1AHUbKX024585	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)	for <gdb-patches@sourceware.org>; Fri, 10 Feb 2012 12:30:37 -0500
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199])	by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q1AHUaP6019182;	Fri, 10 Feb 2012 12:30:37 -0500
Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id q1AHUZ4t000753;	Fri, 10 Feb 2012 12:30:35 -0500
From: Tom Tromey <tromey@redhat.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: RFC: extend symtabs_from_filename skipping for C++
References: <m3aa4taxyg.fsf@fleche.redhat.com>	<20120210133349.GA12398@host2.jankratochvil.net>
Date: Fri, 10 Feb 2012 17:30:00 -0000
In-Reply-To: <20120210133349.GA12398@host2.jankratochvil.net> (Jan	Kratochvil's message of "Fri, 10 Feb 2012 14:33:49 +0100")
Message-ID: <87ehu2eguc.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.93 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-02/txt/msg00205.txt.bz2

>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:

Jan> I failed to find a countercase but wouldn't you prefer:
Jan> -  if (*p != '\0')
Jan> +  if (*p != '\0' && !(p[0] == ':' && p[1] == ':'))

Yeah, that is what I will check in.

Tom