From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20031 invoked by alias); 8 Jun 2012 20:41:10 -0000 Received: (qmail 20023 invoked by uid 22791); 8 Jun 2012 20:41:10 -0000 X-SWARE-Spam-Status: No, hits=-6.5 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 08 Jun 2012 20:40:56 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q58Keun5019265 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 8 Jun 2012 16:40:56 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q58KetK6026884 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Fri, 8 Jun 2012 16:40:55 -0400 From: Tom Tromey To: Jan Kratochvil Cc: gdb-patches@sourceware.org Subject: Re: [patch] Fix "ambiguous linespec" regression: break lineno References: <20120608193958.GA10296@host2.jankratochvil.net> Date: Fri, 08 Jun 2012 20:41:00 -0000 In-Reply-To: <20120608193958.GA10296@host2.jankratochvil.net> (Jan Kratochvil's message of "Fri, 8 Jun 2012 21:39:58 +0200") Message-ID: <87ehppczag.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.97 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-06/txt/msg00247.txt.bz2 >>>>> "Jan" == Jan Kratochvil writes: Jan> It seems somehow clear to me, OK to check it in? I agree it is an improvement. However, why should this apply to linespecs used by 'break' but not by other ones? Jan> + if (last_displayed_sal_is_valid () linespec.c:initialize_defaults has: struct symtab_and_line cursal = get_current_source_symtab_and_line (); It seems like we have two similar notions here -- the "current" source line and the "last displayed" source line. This doesn't make sense to me. Can we not just have a single notion and use it everywhere? If we really need two, can we do the processing in linespec.c? I realize you're just reverting a bit of code - but is that ObjC hack really needed? I'd like us to get away from this kind of thing. Tom