From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7782 invoked by alias); 17 Oct 2012 17:04:44 -0000 Received: (qmail 7772 invoked by uid 22791); 17 Oct 2012 17:04:43 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 17 Oct 2012 17:04:33 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q9HH4VOv021351 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 17 Oct 2012 13:04:31 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q9HH4Toc029744 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Wed, 17 Oct 2012 13:04:30 -0400 From: Tom Tromey To: Joel Brobecker Cc: Andrew Burgess , "gdb-patches\@sourceware.org" Subject: Re: [RFC] Change how value is shown for varobjs of type vector. References: <50631DE7.7050702@broadcom.com> <20121014172527.GC3050@adacore.com> Date: Wed, 17 Oct 2012 17:04:00 -0000 In-Reply-To: <20121014172527.GC3050@adacore.com> (Joel Brobecker's message of "Sun, 14 Oct 2012 10:25:27 -0700") Message-ID: <87ehkx3u8y.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-10/txt/msg00284.txt.bz2 >>>>> "Joel" == Joel Brobecker writes: Andrew> I have a patch (below) that changes the value field from the current Andrew> "[8]" to "{ 0, 0, 0, 0, 0, 0, 0, 0 }". The varobj still has 8 Andrew> children, and the top level varobj is still not editable, you have to Andrew> edit through the children. Joel> I personally do not have a strong objection to this change, but I have Joel> to admit that I am not particularly fond of the idea. I think that Joel> this issue should be handled at the front-end level (Eg. Eclipse), I think so too. Marc> Although I haven't tried, I believe we can figure out this case Marc> should be handled like the array case by improving Eclipse's type Marc> parser to handle the vector_size __attribute__. One thought I had was that, if gdb does not currently emit enough information for Eclipse to treat vectors specially, then we could add a "displayhint" field even to non-dynamic varobjs (or of course emit the needed info in some other way). Tom