From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25072 invoked by alias); 15 Nov 2012 19:28:09 -0000 Received: (qmail 25064 invoked by uid 22791); 15 Nov 2012 19:28:09 -0000 X-SWARE-Spam-Status: No, hits=-6.7 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 15 Nov 2012 19:28:02 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qAFJS2CX029688 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 15 Nov 2012 14:28:02 -0500 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id qAFJS1lO021716 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Thu, 15 Nov 2012 14:28:01 -0500 From: Tom Tromey To: gdb-patches@sourceware.org Subject: [6/10] RFC: don't check for stdlib.h References: <87obiyzns7.fsf@fleche.redhat.com> Date: Thu, 15 Nov 2012 19:28:00 -0000 In-Reply-To: <87obiyzns7.fsf@fleche.redhat.com> (Tom Tromey's message of "Thu, 15 Nov 2012 12:09:12 -0700") Message-ID: <87ehjuy8cf.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-11/txt/msg00428.txt.bz2 I think checking for stdlib.h is useless. gdb includes it unconditionally already. Tom * configure: Rebuild. * configure.ac: Don't check for stdlib.h. * defs.h: Update. * configure: Rebuild. * configure.ac: Don't check for stdlib.h. * gdbreplay.c: Update. --- gdb/configure | 2 +- gdb/configure.ac | 2 +- gdb/defs.h | 3 +-- gdb/gdbserver/configure | 2 +- gdb/gdbserver/configure.ac | 2 +- gdb/gdbserver/gdbreplay.c | 2 -- 6 files changed, 5 insertions(+), 8 deletions(-) diff --git a/gdb/configure.ac b/gdb/configure.ac index 41bed53..ccd8322 100644 --- a/gdb/configure.ac +++ b/gdb/configure.ac @@ -1075,7 +1075,7 @@ AC_HEADER_STDC # elf_hp.h is for HP/UX 64-bit shared library support. AC_CHECK_HEADERS([nlist.h machine/reg.h poll.h sys/poll.h proc_service.h \ thread_db.h \ - stdlib.h sys/fault.h \ + sys/fault.h \ sys/file.h sys/filio.h sys/ioctl.h sys/param.h \ sys/resource.h sys/procfs.h sys/ptrace.h ptrace.h \ sys/reg.h sys/debugreg.h sys/select.h sys/syscall.h \ diff --git a/gdb/defs.h b/gdb/defs.h index 7bb85b0..6d49d8f 100644 --- a/gdb/defs.h +++ b/gdb/defs.h @@ -621,9 +621,8 @@ enum gdb_osabi /* From other system libraries */ -#ifdef HAVE_STDLIB_H #include -#endif + #ifndef min #define min(a, b) ((a) < (b) ? (a) : (b)) #endif diff --git a/gdb/gdbserver/configure.ac b/gdb/gdbserver/configure.ac index ecbb921..a5d636a 100644 --- a/gdb/gdbserver/configure.ac +++ b/gdb/gdbserver/configure.ac @@ -51,7 +51,7 @@ ACX_CONFIGURE_DIR(["../gnulib"], ["build-gnulib-gdbserver"]) AC_CHECK_HEADERS(sgtty.h termio.h termios.h sys/reg.h dnl proc_service.h sys/procfs.h thread_db.h linux/elf.h dnl - stdlib.h unistd.h dnl + unistd.h dnl errno.h fcntl.h sys/file.h malloc.h dnl sys/ioctl.h netinet/in.h sys/socket.h netdb.h dnl netinet/tcp.h arpa/inet.h sys/wait.h wait.h sys/un.h) diff --git a/gdb/gdbserver/gdbreplay.c b/gdb/gdbserver/gdbreplay.c index 2a48c04..22ae9e4 100644 --- a/gdb/gdbserver/gdbreplay.c +++ b/gdb/gdbserver/gdbreplay.c @@ -33,9 +33,7 @@ #if HAVE_ERRNO_H #include #endif -#ifdef HAVE_STDLIB_H #include -#endif #include #ifdef HAVE_UNISTD_H #include -- 1.7.7.6