From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12499 invoked by alias); 14 Dec 2012 19:18:19 -0000 Received: (qmail 12491 invoked by uid 22791); 14 Dec 2012 19:18:18 -0000 X-SWARE-Spam-Status: No, hits=-6.4 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 14 Dec 2012 19:18:10 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qBEJI76P012717 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 14 Dec 2012 14:18:08 -0500 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id qBEJI6WY027675 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Fri, 14 Dec 2012 14:18:07 -0500 From: Tom Tromey To: Hui Zhu Cc: gdb-patches ml , Hui Zhu Subject: Re: [PATCH] Add fseek to ui-file References: <87txryx36w.fsf@fleche.redhat.com> <87lid9x6hl.fsf@fleche.redhat.com> <87vcc9el7d.fsf@fleche.redhat.com> <878v939t6z.fsf@fleche.redhat.com> Date: Fri, 14 Dec 2012 19:18:00 -0000 In-Reply-To: (Hui Zhu's message of "Thu, 13 Dec 2012 09:44:35 +0800") Message-ID: <87ehiszbm9.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-12/txt/msg00515.txt.bz2 >>>>> "Hui" == Hui Zhu writes: Hui> +static int Hui> +null_file_fseek (struct ui_file *stream, long offset, int whence) Hui> +{ Hui> + return -1; Hui> +} It seems like this should set errno as well. Tom