From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23372 invoked by alias); 18 Dec 2012 01:40:35 -0000 Received: (qmail 23356 invoked by uid 22791); 18 Dec 2012 01:40:34 -0000 X-SWARE-Spam-Status: No, hits=-6.4 required=5.0 tests=BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mga12.intel.com (HELO azsmga102.ch.intel.com) (143.182.124.36) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 18 Dec 2012 01:40:30 +0000 Received: from mail-da0-f69.google.com ([209.85.210.69]) by mga14.intel.com with ESMTP/TLS/RC4-SHA; 17 Dec 2012 17:40:29 -0800 Received: by mail-da0-f69.google.com with SMTP id x4so63442daj.4 for ; Mon, 17 Dec 2012 17:40:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:x-received:from:to:subject:date:message-id:user-agent :mime-version:content-type:x-gm-message-state; bh=hFFcWCYBmMz2s6PSKjinLk+OB3OLALXWUiZENf6HGnM=; b=e0MBgpsall7SQyQigN9OOQhLf1uOok+BZ9fFFDzlh7nNRjcDki3GZs9mf3lZ24R5xb BYbX9zTDL/8JWl33CVIyoY2juHjtV0wgyj5cVXywy5GILwzYIvp2QxYvwttwGN9/OYqx XcG1iMobQSdk5qfZ/Sld1mwEWHmhJ6a+PasXISLYGqPi80VWcRdOPiScOBZ1pOqfqlRz +m/gW9O2PsCGXPUAzVSlY7AuyBIyCUEHUWzvCfm01d468WFmD62vDJMg6GX5BZ9FNt8r 6B0n1ZPTuLxSBDbjSqvNHIDbiBEeBNGYa4z6qlp+IaOCo8ewTCILGdyWPx/t3IAbNxQf e1kQ== X-Received: by 10.68.225.101 with SMTP id rj5mr1237775pbc.66.1355794827923; Mon, 17 Dec 2012 17:40:27 -0800 (PST) X-Received: by 10.68.225.101 with SMTP id rj5mr1237762pbc.66.1355794827787; Mon, 17 Dec 2012 17:40:27 -0800 (PST) Received: from wd-workstation.intel.com (c-71-193-205-90.hsd1.or.comcast.net. [71.193.205.90]) by mx.google.com with ESMTPS id k2sm390472paw.24.2012.12.17.17.40.26 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 17 Dec 2012 17:40:26 -0800 (PST) From: William Douglas To: gdb-patches@sourceware.org Subject: [PATCH] print_frame add info Date: Tue, 18 Dec 2012 01:40:00 -0000 Message-ID: <87ehiocel0.fsf@intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.93 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Gm-Message-State: ALoCoQkeZglcv7vrpX4oiJxh/50SsUld+n+AEzsqZqnQyZj/4gsa05JKHJXoO734X/ezmFgzqugKgswx18q3ldEfN4AWmcovN0CmrnkuXs0hNZRcmaH8WKib1S8jSqGiX1VDFUisprrliGrwfb9idRzGedNCGil8hg== X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-12/txt/msg00605.txt.bz2 Hi all, I want to have gdb's output for shared objects' stack frames changed to append the from /path/to/lib.so.1 even if the function name or file name are available. It would make things easier for me when I don't readily know what library a certain file is in and the change doesn't seem especially drastic. Any comments on this change? -- diff --git a/gdb/stack.c b/gdb/stack.c index 51747ea..9d28b74 100644 --- a/gdb/stack.c +++ b/gdb/stack.c @@ -1198,7 +1198,7 @@ print_frame (struct frame_info *frame, int print_level, annotate_frame_source_end (); } - if (pc_p && (!funname || (!sal.symtab || !sal.symtab->filename))) + if (pc_p) { #ifdef PC_SOLIB char *lib = PC_SOLIB (get_frame_pc (frame)); -- William Douglas, Intel Open Source Technology Center