From: Tom Tromey <tromey@redhat.com>
To: Doug Evans <dje@google.com>
Cc: gdb-patches@sourceware.org, ccoutant@google.com, saugustine@google.com
Subject: Re: [RFA] Work around binutils/15021
Date: Thu, 17 Jan 2013 17:53:00 -0000 [thread overview]
Message-ID: <87ehhjd7dk.fsf@fleche.redhat.com> (raw)
In-Reply-To: <yjt24nigsohy.fsf@ruffy2.mtv.corp.google.com> (Doug Evans's message of "Wed, 16 Jan 2013 15:21:29 -0800")
>>>>> "Doug" == Doug Evans <dje@google.com> writes:
Doug> Regression tested with gdb-generated .gdb_index version 7 (by hacking the
Doug> gdb-under-test to generate version 7), version 8, with dwz, and with gold.
I think index version bumps require a documentation update and also a
binutils patch.
Doug> Work around binutils/15021
IIUC, the version bump is part of the workaround for the gold bug,
right? The idea being that gold will generate version 7 indices,
causing gdb to take the "inclusion" path. (I'm just trying to make sure
I understand what is going on.)
Doug> + This is also used to work around a difference between the way gold
Doug> + generates .gdb_index version <=7 and the way gdb does. Arguably this
Doug> + is a gold bug.
To me it doesn't seem arguable, but I'm curious to know what the case is
for it not being a gold bug.
Doug> @@ -19634,7 +19660,7 @@ dwarf2_per_objfile_free (struct objfile
Doug> for (ix = 0; ix < dwarf2_per_objfile->n_comp_units; ++ix)
Doug> VEC_free (dwarf2_per_cu_ptr,
Doug> - dwarf2_per_objfile->all_comp_units[ix]->s.imported_symtabs);
Doug> + dwarf2_per_objfile->all_comp_units[ix]->imported_symtabs);
If follow_die_sig can be called when one TU refers to another TU, then
it seems like the TU could have a non-empty 'imported_symtabs', meaning
that the loop here should also iterate over TUs.
Tom
next prev parent reply other threads:[~2013-01-17 17:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-16 23:21 Doug Evans
2013-01-17 17:53 ` Tom Tromey [this message]
2013-01-17 18:42 ` Doug Evans
2013-01-17 21:04 ` [RFA, doc RFA] " Doug Evans
2013-01-18 7:17 ` Eli Zaretskii
2013-01-18 14:32 ` Tom Tromey
2013-01-24 14:59 ` Regressions with dwz [Re: [RFA] Work around binutils/15021] Jan Kratochvil
[not found] ` <CADPb22SoND17XeXBL2N+-DXf+yKuWe4PJEXR86qT06-q_LA+7g@mail.gmail.com>
2013-01-24 17:16 ` Jan Kratochvil
2013-01-24 19:08 ` Jan Kratochvil
2013-01-30 20:41 ` Tom Tromey
2013-06-09 17:09 ` [RFA] Work around binutils/15021 Jan Kratochvil
2013-06-12 9:49 ` Doug Evans
2013-06-12 18:29 ` Jan Kratochvil
2013-06-12 19:50 ` Cary Coutant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ehhjd7dk.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=ccoutant@google.com \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=saugustine@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox