From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20551 invoked by alias); 7 Mar 2013 15:18:39 -0000 Received: (qmail 20537 invoked by uid 22791); 7 Mar 2013 15:18:37 -0000 X-SWARE-Spam-Status: No, hits=-6.7 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 07 Mar 2013 15:18:29 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r27FISGq005810 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 7 Mar 2013 10:18:28 -0500 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r27FIRBg018434 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Thu, 7 Mar 2013 10:18:28 -0500 From: Tom Tromey To: Keith Seitz Cc: "gdb-patches\@sourceware.org ml" Subject: Re: [RFA] cleanup: while (isspace) -> skip_spaces{,_const} References: <5137EE7A.9080500@redhat.com> Date: Thu, 07 Mar 2013 15:18:00 -0000 In-Reply-To: <5137EE7A.9080500@redhat.com> (Keith Seitz's message of "Wed, 06 Mar 2013 17:33:46 -0800") Message-ID: <87ehfri6gs.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.92 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-03/txt/msg00294.txt.bz2 >>>>> "Keith" == Keith Seitz writes: Keith> I've audited the code and changed all of these places (except for Keith> strcmp_iw and friends, where the inlined version is probably better). Keith> Comments? This patch is ok. thanks, Tom