From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-99445-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 18418 invoked by alias); 12 Mar 2013 15:27:57 -0000
Received: (qmail 18410 invoked by uid 22791); 12 Mar 2013 15:27:57 -0000
X-SWARE-Spam-Status: No, hits=-7.7 required=5.0	tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 12 Mar 2013 15:27:48 +0000
Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r2CFRhRk019670	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Tue, 12 Mar 2013 11:27:43 -0400
Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r2CFRfol017765	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO);	Tue, 12 Mar 2013 11:27:42 -0400
From: Tom Tromey <tromey@redhat.com>
To: Hui Zhu <teawater@gmail.com>
Cc: Hui Zhu <hui_zhu@mentor.com>, Yao Qi <yao@codesourcery.com>,        gdb-patches ml <gdb-patches@sourceware.org>,        Joel Brobecker <brobecker@adacore.com>
Subject: Re: [PATCH] Fix agent code generate bug of ref
References: <CANFwon0GXGwSqOyev+te3f0DBCqG3y0ovJ+yJ-kcaWkMAJOwXw@mail.gmail.com>	<513DDE2C.9080109@codesourcery.com> <87r4jmngr5.fsf@fleche.redhat.com>	<87k3penfy3.fsf@fleche.redhat.com>	<CANFwon0UqJtN2O7poC8d0X+puqR-LCfw368qKJJs50YE_wexZA@mail.gmail.com>	<87y5dsityl.fsf@fleche.redhat.com> <513F4028.5090000@mentor.com>	<87txogir7j.fsf@fleche.redhat.com>	<CANFwon2Q0NjeOSgq96SQ_h4ktup2=ye+y9EmYYKBoqrUYjQjVg@mail.gmail.com>
Date: Tue, 12 Mar 2013 15:27:00 -0000
In-Reply-To: <CANFwon2Q0NjeOSgq96SQ_h4ktup2=ye+y9EmYYKBoqrUYjQjVg@mail.gmail.com>	(Hui Zhu's message of "Tue, 12 Mar 2013 23:24:42 +0800")
Message-ID: <87ehfkiqoi.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2013-03/txt/msg00521.txt.bz2

>>>>> "Hui" == Hui Zhu <teawater@gmail.com> writes:

Hui> On Tue, Mar 12, 2013 at 11:16 PM, Tom Tromey <tromey@redhat.com> wrote:
>>>>>>> "Hui" == Hui Zhu <hui_zhu@mentor.com> writes:
>> 
Hui> According to the discussion with Tom in IRC.
Hui> I add a check before call access_memory.
Hui> +      if (size != 1 && size != 2 && size != 4 && size != 8)
Hui> +        error (_("Refn doesn't support size %d"),
Hui> +               size * TARGET_CHAR_BIT);

>> The old error message mentioned the actual opcode name.
>> I think "Refn" is less clear, since it isn't the name of anything
>> in DWARF.

Hui> What about change it to "DW_OP_deref and DW_OP_deref_size"?

It seems simple to just resurrect the old error message.

Tom