From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19246 invoked by alias); 19 Apr 2013 14:41:22 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 19236 invoked by uid 89); 19 Apr 2013 14:41:22 -0000 X-Spam-SWARE-Status: No, score=-6.8 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Fri, 19 Apr 2013 14:41:21 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r3JEfK0F011971 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 19 Apr 2013 10:41:20 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r3JEfICO031485 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Fri, 19 Apr 2013 10:41:19 -0400 From: Tom Tromey To: gdb-patches@sourceware.org Subject: [PATCH 22/28] remove erroneous incref from gdbpy_initialize_py_events References: <87ehe638ww.fsf@fleche.redhat.com> Date: Fri, 19 Apr 2013 16:55:00 -0000 In-Reply-To: <87ehe638ww.fsf@fleche.redhat.com> (Tom Tromey's message of "Fri, 19 Apr 2013 08:13:51 -0600") Message-ID: <87ehe6y44x.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2013-04/txt/msg00606.txt.bz2 The checker noticed a bogus incref in gdbpy_initialize_py_events. * python/py-evts.c (gdbpy_initialize_py_events): Don't incref the module. --- gdb/python/py-evts.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/gdb/python/py-evts.c b/gdb/python/py-evts.c index bb384e3..4828bda 100644 --- a/gdb/python/py-evts.c +++ b/gdb/python/py-evts.c @@ -81,9 +81,6 @@ gdbpy_initialize_py_events (void) if (add_new_registry (&gdb_py_events.new_objfile, "new_objfile") < 0) return -1; -#ifndef IS_PY3K - Py_INCREF (gdb_py_events.module); -#endif if (PyModule_AddObject (gdb_module, "events", (PyObject *) gdb_py_events.module) < 0) -- 1.8.1.4