From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-101384-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 16988 invoked by alias); 10 May 2013 15:24:09 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 16977 invoked by uid 89); 10 May 2013 15:24:08 -0000
X-Spam-SWARE-Status: No, score=-6.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS,TW_RG autolearn=ham version=3.3.1
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Fri, 10 May 2013 15:24:08 +0000
Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r4AFM22f016982	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Fri, 10 May 2013 11:22:02 -0400
Received: from barimba (ovpn-113-133.phx2.redhat.com [10.3.113.133])	by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r4AFLww5020030	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO);	Fri, 10 May 2013 11:21:59 -0400
From: Tom Tromey <tromey@redhat.com>
To: Hui Zhu <teawater@gmail.com>
Cc: Pedro Alves <palves@redhat.com>, Eli Zaretskii <eliz@gnu.org>,        Hui Zhu <hui_zhu@mentor.com>,        gdb-patches ml <gdb-patches@sourceware.org>,        Marc Khouzam <marc.khouzam@ericsson.com>
Subject: Re: [PATCH] add -s option to make -break-insert support dprintf
References: <515451EA.1000200@mentor.com> <83y5d7wpvq.fsf@gnu.org>	<CANFwon23qn_SVjcUWUZ2Z2Y5Euqg8efiwMvXkxTRtA9-2Ttk3Q@mail.gmail.com>	<516454DA.9040109@redhat.com>	<CANFwon1aDoyCYrsNeUpkmh6ARFJmT8B4JdFqYcc6GLdo=cgqig@mail.gmail.com>	<87ppxzhfqy.fsf@fleche.redhat.com>	<CANFwon2_yT4SOpK7=Rq=91nFcvk2Rn3_wAkCMmsfgP-6iynGig@mail.gmail.com>	<516C2549.3060808@redhat.com>	<CANFwon0WYLZEKWkfHzRgCB8MOPPoCsDvSaCk0SSYXPgonuE5zw@mail.gmail.com>	<87vc7ithtj.fsf@fleche.redhat.com>	<CANFwon0jwdrDULV+bPRX_5AWE2tgq=rSrA6eyZEujZqPfN+Huw@mail.gmail.com>	<87wqrrll9m.fsf@fleche.redhat.com>	<CANFwon3yyKxMVRO3wJ3=VTDLpege_NWByMA9-jk_g9_a5mXaoQ@mail.gmail.com>	<87d2t2tt02.fsf@fleche.redhat.com>	<CANFwon3meTbHqy-kfibR6XiJpkZdS3348am2wP6i9Dbz_sowLg@mail.gmail.com>
Date: Fri, 10 May 2013 15:24:00 -0000
In-Reply-To: <CANFwon3meTbHqy-kfibR6XiJpkZdS3348am2wP6i9Dbz_sowLg@mail.gmail.com>	(Hui Zhu's message of "Fri, 10 May 2013 18:56:53 +0800")
Message-ID: <87ehdehnc9.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-SW-Source: 2013-05/txt/msg00390.txt.bz2

Hui> +	  if (isprint(argv[0][i]))

Missing space before "(".

Hui> +	      char tmp[5];
Hui> +	      sprintf (tmp, "\\%o", (unsigned char)argv[0][i]);

Missing newline between these lines.
Missing space after ")".

Hui> +  if (dprintf)
Hui> +    {
Hui> +      int format_num = oind + 1;
Hui> +
Hui> +      if (hardware || tracepoint)
Hui> +	error (_("-dprintf-insert: does not support -h or -a"));
Hui> +      if (format_num >= argc)
Hui> +	error (_("-dprintf-insert: Missing <format>"));
Hui> +
Hui> +      extra_string = mi_argv_to_format (argv + format_num, argc - format_num);
Hui> +      extra_string_cleanup = make_cleanup (xfree, extra_string);

It is better to just install an outer null cleanup and invoke that at
the end.

Tom