From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21898 invoked by alias); 17 May 2013 16:27:21 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 21889 invoked by uid 89); 17 May 2013 16:27:21 -0000 X-Spam-SWARE-Status: No, score=-6.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Fri, 17 May 2013 16:27:13 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r4HGRAI1016951 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 17 May 2013 12:27:10 -0400 Received: from barimba (ovpn-113-158.phx2.redhat.com [10.3.113.158]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r4HGR9cc028208 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Fri, 17 May 2013 12:27:09 -0400 From: Tom Tromey To: Joel Brobecker Cc: Keith Seitz , "gdb-patches\@sourceware.org ml" Subject: Re: [RFA] completer test [was Re: [RFC] Cleanup for make_source_files_completion_list] References: <5191340B.60100@redhat.com> <519156F5.5090000@redhat.com> <5193C786.4000207@redhat.com> <5193E2DC.5000200@redhat.com> <51941E85.8010104@redhat.com> <20130516053008.GA5555@adacore.com> <20130516054906.GB5555@adacore.com> <5194FE2A.7000205@redhat.com> <20130517051435.GC4017@adacore.com> Date: Fri, 17 May 2013 16:27:00 -0000 In-Reply-To: <20130517051435.GC4017@adacore.com> (Joel Brobecker's message of "Fri, 17 May 2013 09:14:35 +0400") Message-ID: <87ehd5r2qr.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2013-05/txt/msg00687.txt.bz2 >>>>> "Joel" == Joel Brobecker writes: Joel> I suspect we are going to find a large number of issues in Joel> ada-lang, simply because I never quite grasped the fact that Joel> cleanups should not be leaked under normal execution (only Joel> when an exception is raised, in which case they get automatically Joel> performed). The checker found two -- the one you fixed in ada_make_symbol_completion_list, and also a dangling cleanup in old_renaming_is_invisible. This one seemed hard to fix and so in my patch series I just punted on it by marking it with the dangling_cleanup attribute. Tom