From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14954 invoked by alias); 20 May 2013 14:47:56 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 14916 invoked by uid 89); 20 May 2013 14:47:51 -0000 X-Spam-SWARE-Status: No, score=-6.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Mon, 20 May 2013 14:47:51 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r4KElmpP026955 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 20 May 2013 10:47:48 -0400 Received: from barimba (ovpn-113-72.phx2.redhat.com [10.3.113.72]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r4KElkii005702 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Mon, 20 May 2013 10:47:47 -0400 From: Tom Tromey To: Joel Brobecker Cc: gdb-patches@sourceware.org Subject: Re: [RFA] completer test [was Re: [RFC] Cleanup for make_source_files_completion_list] References: <519156F5.5090000@redhat.com> <5193C786.4000207@redhat.com> <5193E2DC.5000200@redhat.com> <51941E85.8010104@redhat.com> <20130516053008.GA5555@adacore.com> <20130516054906.GB5555@adacore.com> <5194FE2A.7000205@redhat.com> <20130517051435.GC4017@adacore.com> <87ehd5r2qr.fsf@fleche.redhat.com> <20130520052818.GK4017@adacore.com> Date: Mon, 20 May 2013 14:47:00 -0000 In-Reply-To: <20130520052818.GK4017@adacore.com> (Joel Brobecker's message of "Mon, 20 May 2013 09:28:18 +0400") Message-ID: <87ehd1ogh9.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2013-05/txt/msg00729.txt.bz2 >>>>> "Joel" == Joel Brobecker writes: Joel> Do you see something obviously wrong with the attached patch? Joel> I haven't tested it yet, and I am not sure how much I can test it, Joel> given that old-style renamings have been replaced 6 years ago. Joel> I was looking at the option of removing support for them, but Joel> I actually know of some users still using an ancient version Joel> of the compiler but with a new version of the debugger... For some reason I thought the function needed to leave a dangling cleanup, but I see now I was mistaken. It looks good to me. Tom