From: Tom Tromey <tromey@redhat.com>
To: Phil Muldoon <pmuldoon@redhat.com>
Cc: "gdb-patches\@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [patch] [python] PR python/15461 (gate architecture calls)
Date: Wed, 28 Aug 2013 15:54:00 -0000 [thread overview]
Message-ID: <87eh9dx12o.fsf@fleche.redhat.com> (raw)
In-Reply-To: <521E1419.5040404@redhat.com> (Phil Muldoon's message of "Wed, 28 Aug 2013 16:15:37 +0100")
Phil> I don't disagree on the efficiency argument, but my goal here was to
Phil> follow the pattern that other objects use to determine validity of the
Phil> underlying GDB data. To bring a sense of uniformity to how we do
Phil> things in Python. So how we check a gdb.Frame's, et al, validity, the
Phil> pattern will be the same, as far as possible, for other objects.
Ok.
If you look at other ones, they set the Python exception. At least that
is true for py-block.c (twice), py-inferior.c, py-inthread.c,
py-symbol.c, py-symtab.c (twice), etc.
FWIW I don't mind inconsistency in these little details. What matters
is the context in which the macro is most useful.
Tom
next prev parent reply other threads:[~2013-08-28 15:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-28 12:04 Phil Muldoon
2013-08-28 14:52 ` Tom Tromey
2013-08-28 15:15 ` Phil Muldoon
2013-08-28 15:54 ` Tom Tromey [this message]
2013-08-29 11:15 ` Phil Muldoon
2013-08-29 14:58 ` Tom Tromey
2013-08-30 10:13 ` Phil Muldoon
2013-08-28 17:54 ` Tom Tromey
2013-08-28 18:14 ` Paul_Koning
2013-08-28 18:45 ` Phil Muldoon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eh9dx12o.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=pmuldoon@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox