From: Tom Tromey <tromey@redhat.com>
To: Muhammad Waqas <mwaqas@codesourcery.com>
Cc: "Agovic\, Sanimir" <sanimir.agovic@intel.com>,
"gdb-patches\@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH] PR 15520 - GDB step command crashed on non-stop mode
Date: Thu, 07 Nov 2013 15:14:00 -0000 [thread overview]
Message-ID: <87eh6sz1qm.fsf@fleche.redhat.com> (raw)
In-Reply-To: <52380BE7.7050505@codesourcery.com> (Muhammad Waqas's message of "Tue, 17 Sep 2013 12:59:35 +0500")
>>>>> ">" == Muhammad Waqas <mwaqas@codesourcery.com> writes:
>> 2013-09-13 Muhammad Waqas <mwaqas@codesourcery.com>
>> PR 15520
It's more usual to use the component in here as well.
I'm not sure whether the commit script's regex will match the above.
So it would be:
PR threads/15520
>> *gdb.base/pr15520.cc: New file.
>> *gdb.base/pr15520.exp: New file.
Two notes here.
First, space after the "*".
Second, we generally don't use the PR number in the test case file names.
Instead we try to use a descriptive name.
I don't fully understand the fix itself.
Maybe you could walk me through it.
Tom
prev parent reply other threads:[~2013-11-07 15:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-16 8:11 Muhammad Waqas
2013-09-17 7:19 ` Agovic, Sanimir
2013-09-17 7:59 ` Muhammad Waqas
2013-09-20 12:08 ` Muhammad Waqas
2013-10-07 11:32 ` Muhammad Waqas
2013-11-07 15:14 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eh6sz1qm.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=mwaqas@codesourcery.com \
--cc=sanimir.agovic@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox