From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1611 invoked by alias); 15 Jan 2014 21:07:03 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 1600 invoked by uid 89); 15 Jan 2014 21:07:02 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.1 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 15 Jan 2014 21:07:01 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s0FL6vM6022317 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 15 Jan 2014 16:06:57 -0500 Received: from barimba (ovpn-113-85.phx2.redhat.com [10.3.113.85]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id s0FL6tWL006571 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Wed, 15 Jan 2014 16:06:56 -0500 From: Tom Tromey To: Sanimir Agovic Cc: palves@redhat.com, xdje42@gmail.com, gdb-patches@sourceware.org, keven.boell@intel.com Subject: Re: [PATCH v4 02/13] type: add c99 variable length array support References: <1387282678-3847-1-git-send-email-sanimir.agovic@intel.com> <1387282678-3847-3-git-send-email-sanimir.agovic@intel.com> Date: Wed, 15 Jan 2014 21:07:00 -0000 In-Reply-To: <1387282678-3847-3-git-send-email-sanimir.agovic@intel.com> (Sanimir Agovic's message of "Tue, 17 Dec 2013 13:17:47 +0100") Message-ID: <87eh49osy8.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2014-01/txt/msg00565.txt.bz2 >>>>> "Sanimir" == Sanimir Agovic writes: Sanimir> +int Sanimir> +dwarf2_evaluate_property (const struct dynamic_prop *prop, CORE_ADDR address, Sanimir> + CORE_ADDR *value) Sanimir> +{ [...] Sanimir> + if (!value_optimized_out (val)) Sanimir> + *value = value_as_long (value_ind (val)); Sanimir> + } Sanimir> + return 1; This particular branch can return 1 but not set *value. That seems wrong. Sanimir> + else if (attr_form_is_block (target_attr)) Sanimir> + { Sanimir> + const gdb_byte ops[] = {DW_OP_deref}; Sanimir> + Sanimir> + baton = obstack_alloc (obstack, sizeof (*baton)); Sanimir> + baton->locexpr = block_to_locexpr_baton (DW_BLOCK (target_attr), Sanimir> + cu, ops, sizeof (ops)); I noted in an earlier review that I think this approach will not work. Not sure if I'm misunderstanding something; but I dug up the old thread and you didn't respond to this bit: https://sourceware.org/ml/gdb-patches/2013-11/msg00785.html The rest of this seemed fine to me. Tom