From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31871 invoked by alias); 17 Apr 2014 09:48:21 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 31857 invoked by uid 89); 17 Apr 2014 09:48:21 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_NEUTRAL autolearn=no version=3.3.2 X-HELO: sasl.smtp.pobox.com Received: from a-pb-sasl-quonix.pobox.com (HELO sasl.smtp.pobox.com) (208.72.237.25) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 17 Apr 2014 09:48:20 +0000 Received: from sasl.smtp.pobox.com (unknown [127.0.0.1]) by a-pb-sasl-quonix.pobox.com (Postfix) with ESMTP id B93DE11E5E; Thu, 17 Apr 2014 05:48:18 -0400 (EDT) Received: from a-pb-sasl-quonix.pobox.com (unknown [127.0.0.1]) by a-pb-sasl-quonix.pobox.com (Postfix) with ESMTP id B053C11E5D; Thu, 17 Apr 2014 05:48:18 -0400 (EDT) Received: from rusty (unknown [88.160.190.192]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by a-pb-sasl-quonix.pobox.com (Postfix) with ESMTPSA id 4B08911E5C; Thu, 17 Apr 2014 05:48:17 -0400 (EDT) From: Andy Wingo To: Doug Evans Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 7/9] Remove Guile mark functions that don't mark anything References: <1397060028-18158-1-git-send-email-wingo@igalia.com> <1397060028-18158-8-git-send-email-wingo@igalia.com> Date: Thu, 17 Apr 2014 09:48:00 -0000 In-Reply-To: (Doug Evans's message of "Sat, 12 Apr 2014 12:29:43 -0700") Message-ID: <87eh0ws2w1.fsf@igalia.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: 66E77300-C615-11E3-B5E1-873F0E5B5709-02397024!a-pb-sasl-quonix.pobox.com X-SW-Source: 2014-04/txt/msg00343.txt.bz2 On Sat 12 Apr 2014 21:29, Doug Evans writes: > Andy Wingo writes: > >> * gdb/guile/scm-arch.c (arscm_mark_arch_smob): >> * gdb/guile/scm-block.c (bkscm_mark_block_smob) >> (bkscm_mark_block_syms_progress_smob): >> * gdb/guile/scm-frame.c (frscm_mark_frame_smob): >> * gdb/guile/scm-lazy-string.c (arscm_mark_arch_smob): >> * gdb/guile/scm-symbol.c (lsscm_mark_lazy_string_smob): >> * gdb/guile/scm-symtab.c (syscm_mark_symbol_smob): >> * gdb/guile/scm-type.c (tyscm_mark_type_smob): Remove useless mark >> functions. >> --- >> gdb/guile/scm-arch.c | 9 --------- >> gdb/guile/scm-block.c | 19 ------------------- >> gdb/guile/scm-frame.c | 9 --------- >> gdb/guile/scm-lazy-string.c | 9 --------- >> gdb/guile/scm-symbol.c | 9 --------- >> gdb/guile/scm-symtab.c | 9 --------- >> gdb/guile/scm-type.c | 9 --------- >> 7 files changed, 73 deletions(-) > > This is ok with the requisite changelog entry corrections. > > These functions were useful during early development, but I guess we're > passed that point now. Just FYI, mark functions are actively harmful, and should be avoided if possible. They slow down allocation, slow down GC, and, more importantly, are very tricky to write correctly. See: https://lists.gnu.org/archive/html/guile-user/2011-11/msg00069.html Regards, Andy