From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9597 invoked by alias); 5 Jun 2014 18:21:10 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 9587 invoked by uid 89); 5 Jun 2014 18:21:09 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 05 Jun 2014 18:21:08 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s55IL5TF026068 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 5 Jun 2014 14:21:05 -0400 Received: from barimba ([10.3.113.4]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s55IL3ui026470 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=NO); Thu, 5 Jun 2014 14:21:04 -0400 From: Tom Tromey To: Yao Qi Cc: Subject: Re: [PATCH 02/12] Generalize varobj iterator References: <1392367471-13527-1-git-send-email-yao@codesourcery.com> <1392367471-13527-3-git-send-email-yao@codesourcery.com> <874n0jkokw.fsf@fleche.redhat.com> <537EA293.2050000@codesourcery.com> <87k38wa0k6.fsf@fleche.redhat.com> <53900166.7080900@codesourcery.com> Date: Thu, 05 Jun 2014 18:21:00 -0000 In-Reply-To: <53900166.7080900@codesourcery.com> (Yao Qi's message of "Thu, 5 Jun 2014 13:34:30 +0800") Message-ID: <87egz36wvk.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2014-06/txt/msg00280.txt.bz2 >>>>> "Yao" == Yao Qi writes: Yao> Ah, you are right. Call varobj_ensure_python_env in Yao> py_varobj_iter_dtor then. Thanks. Yao> 2014-06-05 Pedro Alves Yao> Yao Qi Yao> * Makefile.in (SUBDIR_PYTHON_OBS): Add "py-varobj.o". Yao> (SUBDIR_PYTHON_SRCS): Add "python/py-varobj.c". Yao> (HFILES_NO_SRCDIR): Add "varobj-iter.h". Yao> (py-varobj.o): New rule. Yao> * python/py-varobj.c: New file. Yao> * python/python-internal.h (py_varobj_get_iterator): Declare. Yao> * varobj-iter.h: New file. Yao> * varobj.c: Include "varobj-iter.h" Yao> (struct varobj) : Change its type from "PyObject *" Yao> to "struct varobj_iter *". Yao> : Likewise. Yao> [HAVE_PYTHON] (varobj_ensure_python_env): Make it extern. Yao> [HAVE_PYTHON] (varobj_get_iterator): New function. Yao> (update_dynamic_varobj_children) [HAVE_PYTHON]: Move Yao> python-specific code to python/py-varobj.c. Yao> (install_visualizer): Call varobj_iter_delete instead of Yao> Py_XDECREF. Yao> * varobj.h (varobj_ensure_python_env): Declare. This is ok. Tom