From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8898 invoked by alias); 19 Sep 2014 09:08:30 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 8880 invoked by uid 89); 19 Sep 2014 09:08:27 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 19 Sep 2014 09:08:27 +0000 Received: from svr-orw-fem-04.mgc.mentorg.com ([147.34.97.41]) by relay1.mentorg.com with esmtp id 1XUuAx-0007Sp-Lx from Yao_Qi@mentor.com ; Fri, 19 Sep 2014 02:08:23 -0700 Received: from GreenOnly (147.34.91.1) by svr-orw-fem-04.mgc.mentorg.com (147.34.97.41) with Microsoft SMTP Server id 14.3.181.6; Fri, 19 Sep 2014 02:08:23 -0700 From: Yao Qi To: Doug Evans CC: Subject: Re: [PATCH 1/3] Check function is GC'ed References: <53D8A264.1050103@codesourcery.com> <1408609338-17561-1-git-send-email-yao@codesourcery.com> <21495.32892.341399.802579@ruffy2.mtv.corp.google.com> <87sikggadr.fsf@codesourcery.com> <21527.13753.980949.662368@ruffy2.mtv.corp.google.com> <87ioko1ec0.fsf@codesourcery.com> <21531.2907.799313.742622@ruffy2.mtv.corp.google.com> Date: Fri, 19 Sep 2014 09:08:00 -0000 In-Reply-To: <21531.2907.799313.742622@ruffy2.mtv.corp.google.com> (Doug Evans's message of "Thu, 18 Sep 2014 09:42:03 -0700") Message-ID: <87egv8yoa5.fsf@codesourcery.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2014-09/txt/msg00625.txt.bz2 Doug Evans writes: > > gdb: > >=20 > > 2014-09-16 Yao Qi > >=20 > > * dwarf2read.c (dwarf_decode_lines): Update declaration. > > (handle_DW_AT_stmt_list): Add argument 'lowpc'. Update > > comments. Callers update. > > (dwarf_decode_lines): Likewise. > > (dwarf_decode_lines_1): Add argument 'lowpc'. Update > > comments. Skip the line table if 'lowpc' is greater than > > 'address'. Don't check > > dwarf2_per_objfile->has_section_at_zero. > >=20 > > gdb/testsuite: > >=20 > > 2014-09-16 Yao Qi > >=20 > > * gdb.base/break-on-linker-gcd-function.exp: Move test into new > > proc set_breakpoint_on_gcd_function. Invoke > > set_breakpoint_on_gcd_function. Restart GDB with --readnow and > > invoke set_breakpoint_on_gcd_function again. > > LGTM. Thanks for the review. Patch is pushed in. --=20 Yao (=E9=BD=90=E5=B0=A7)