From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16434 invoked by alias); 14 Oct 2014 18:53:17 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 16423 invoked by uid 89); 14 Oct 2014 18:53:17 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.1 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 14 Oct 2014 18:53:16 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s9EIrCjA031721 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 14 Oct 2014 14:53:13 -0400 Received: from localhost (dhcp-10-15-16-169.yyz.redhat.com [10.15.16.169]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s9EIrBqr008081 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=NO); Tue, 14 Oct 2014 14:53:12 -0400 From: Sergio Durigan Junior To: "Jose E. Marchesi" Cc: gdb-patches@sourceware.org Subject: Re: [PATCH V2 3/9] New commands `enable probe' and `disable probe'. References: <1412961772-16249-1-git-send-email-jose.marchesi@oracle.com> <1412961772-16249-4-git-send-email-jose.marchesi@oracle.com> X-URL: http://blog.sergiodj.net Date: Tue, 14 Oct 2014 18:53:00 -0000 In-Reply-To: <1412961772-16249-4-git-send-email-jose.marchesi@oracle.com> (Jose E. Marchesi's message of "Fri, 10 Oct 2014 19:22:46 +0200") Message-ID: <87eguaqy94.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2014-10/txt/msg00361.txt.bz2 Hi Jose, Thanks for the v2! Looks great. Just a minor nit. On Friday, October 10 2014, Jose E. Marchesi wrote: > diff --git a/gdb/probe.c b/gdb/probe.c > index 69ca0aa..c548b27 100644 > --- a/gdb/probe.c > +++ b/gdb/probe.c > @@ -527,6 +527,24 @@ exists_probe_with_pops (VEC (bound_probe_s) *probes, > return 0; > } > > +/* Helper function that parses a probe linespec of the form [PROVIDER > + [PROBE [OBJNAME]]] from the provided string STR. */ > + > +static void > +parse_probe_linespec (const char *str, char **provider, > + char **probe_name, char **objname) > +{ > + *probe_name = *objname = NULL; > + > + *provider = extract_arg_const (&str); > + if (*provider) Ops, another implicit comparison :-). > + { > + *probe_name = extract_arg_const (&str); > + if (*probe_name) Here too. > + *objname = extract_arg_const (&str); > + } > +} > + Looks good to me otherwise. -- Sergio GPG key ID: 0x65FC5E36 Please send encrypted e-mail if possible http://sergiodj.net/