From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17871 invoked by alias); 20 Oct 2014 19:39:33 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 17860 invoked by uid 89); 20 Oct 2014 19:39:32 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.8 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 20 Oct 2014 19:39:30 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s9KJdNiE026459 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 20 Oct 2014 15:39:23 -0400 Received: from localhost (dhcp-10-15-16-169.yyz.redhat.com [10.15.16.169]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s9KJdMPv024322 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=NO); Mon, 20 Oct 2014 15:39:23 -0400 From: Sergio Durigan Junior To: Gabriel Krisman Bertazi Cc: Doug Evans , gdb-patches Subject: Re: [RFC PATCH 2/3] Add support to catch groups of syscalls. References: <1412736678-2760-1-git-send-email-gabriel@krisman.be> <1412736678-2760-3-git-send-email-gabriel@krisman.be> <87h9zebcsb.fsf@redhat.com> <87siiy9vis.fsf@redhat.com> <87k34555se.fsf@anubis.Home> <87oat7736y.fsf@anubis.Home> X-URL: http://blog.sergiodj.net Date: Mon, 20 Oct 2014 19:39:00 -0000 In-Reply-To: <87oat7736y.fsf@anubis.Home> (Gabriel Krisman Bertazi's message of "Mon, 20 Oct 2014 02:52:37 -0200") Message-ID: <87egu28r9x.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-IsSubscribed: yes X-SW-Source: 2014-10/txt/msg00519.txt.bz2 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Content-length: 2447 On Monday, October 20 2014, Gabriel Krisman Bertazi wrote: >> I'm not really comfortable with that (far more so than "catch syscall >> open network-group"). >> If you want to require -g at the front, and thus disallow catching >> both syscalls and syscall groups in the same command then that would >> be fine with me. > > I really think we shouldn't disallow catching syscalls and syscalls > group on the same command, no matter which syntax we pick. GDB wiki > says that GDB should be more permissive about command's syntax, in a > sense that user shouldn't spend more time than needed to find out how a > command works. I think disallowing catching syscalls and groups on the > same command would reduce expressiveness in this case. I agree. >> Still need a solution for listing them. Arguably since we don't >> provide a way to list syscalls (sigh, modulo the hack I showed, which >> should be fixed so that it no longer works anyways :-)), providing a >> way to list syscall groups is for a separate patch. Kudos if you >> still want to provide a way to list syscalls and groups though. > > So, definitively allowing "catch syscall -g" to list syscalls is not a > good idea. Sergio suggested off-list to use another option, maybe -lg > to list syscall groups. Then, a future patch could also extend catch > syscall to list all syscalls using a -l option or something like that. > Sergio, sorry if I got your suggestion wrong. It is alright, I completely forgot I made that suggestion! Thanks for bringing it to the table. Anyway, yeah, I guess '-lg' (or -list-groups) should be OK. > OTOH, I might be over-thinking this simple stuff :). I'm ok with the > namespace (suffix) syntax, but I think we should go with "g:" (or even > "group:network", if it's not too verbose) instead of "-group", to avoid > the issue pointed out by Sergio with the exit_group syscall. Yeah, maybe this is a bit over-thinking, but OTOH we are talking about user interface, which cannot be changed easily after we make a release. BTW, I like the idea of using the "g:" prefix, so I say "go for it" if you think it is OK. Sorry for not being able to comment more on the thread now, I am busy with other things. However, I think you covered all the issues with your message, so you should be good to go as long as Doug has no other comments. Cheers, --=20 Sergio GPG key ID: 0x65FC5E36 Please send encrypted e-mail if possible http://sergiodj.net/ --=-=-= Content-Type: application/pgp-signature Content-length: 818 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJURWTqAAoJENDrdihl/F42ctgQAJLz2QIKzn7K3uYyti0DHkG1 hSFLmt5Db0IfgxHSsJurzU+ErSEzapky3e17iifl9BEwAFyV2fvZSxZ8Wpbrigtr jR66E5eN3Xa+zqHQ73GtDDFOJbLMAo8DvFn9I6zfMwYU8eo85gfsKj+cU56p1dIQ nypky+nA6vMzKIxMdNYXmZpX2c14D6RMXJwLpmfL9Mrj1bV6ooL1zAq+YL2XZUVl ivnnSiUPxvziq15NnNxE7z2MLPeg4hRrCBOqTvM4h4x9TG+eyQZpDioqvy4KTndp n9tabBTan0jUmyJYfBdSd5LiZS2NHMPieJ7+1oWUY/z/ZTfP46tXQRr/sLqRajNF rM4Vi7sueGamn3PqAddhc9ectJiysaV03499QwObkJbYzsrZ506mI7hS0oBOdR18 Mn0dc2kyALDxIrZiKNcJ9jHy2kjgWCNlh4zYg5BFa0ObXgIuJXGIPakbSyULD0Tf 3WxzowmcPqc1zPMZ3UUbnaoD5JhfXWWnbn9u6KfZYQ9yYA2mU1mF4NQ6ge8Ux3zQ WEs2BYJs11l2y7DJOrdkBy2sfumBVKwfO8z9DWg3nUMGD15YQtXsdD5rlLv7csJe kIWwCeOvgdGF4ysfy71N1IJd4iTR1DnOvI+3ModOFPBrurtBa8daWJI7BtYLIJML ePX8grRlxIOPmD15zkK5 =tUvm -----END PGP SIGNATURE----- --=-=-=--