Re: [RFA v2 2/2] Fix PR python/17386 - add __index__ method to gdb.Value

Ulrich Weigand
2016-05-25T13:48:06Z

Tom Tromey wrote:

> PR python/17386:
> * python/py-value.c (value_object_as_number): Add
> nb_inplace_floor_divide, nb_inplace_true_divide, nb_index.

This causes a failure on my RHEL5 test system (using Python 2.4):
gdb/python/py-value.c:1848: error: too many initializers for Ã¢Â€Â˜PyNumberMethodsÃ¢Â€Â™

> +#ifndef HAVE_LIBPYTHON_2_4
> + /* This was added in Python 2.5. */
> + , valpy_long /* nb_index */
> +#endif /* HAVE_LIBPYTHON_2_4 */

Nothing defines HAVE_LIBPYTHON_2_4 on my machine; instead, we seem to have

/* Define if Python 2.4 is being used. */
#define HAVE_LIBPYTHON2_4 1

in config.h ... Typo?

Bye,
Ulrich

--
Dr. Ulrich Weigand
GNU/Linux compilers and toolchain
Ulrich.Weigand@de.ibm.com