From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 112985 invoked by alias); 13 Oct 2016 02:04:10 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 112871 invoked by uid 89); 13 Oct 2016 02:04:10 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy= X-HELO: gproxy8-pub.mail.unifiedlayer.com Received: from gproxy8-pub.mail.unifiedlayer.com (HELO gproxy8-pub.mail.unifiedlayer.com) (67.222.33.93) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with SMTP; Thu, 13 Oct 2016 02:04:00 +0000 Received: (qmail 12660 invoked by uid 0); 13 Oct 2016 02:03:58 -0000 Received: from unknown (HELO cmgw3) (10.0.90.84) by gproxy8.mail.unifiedlayer.com with SMTP; 13 Oct 2016 02:03:58 -0000 Received: from box522.bluehost.com ([74.220.219.122]) by cmgw3 with id uq2v1t00N2f2jeq01q2yk5; Wed, 12 Oct 2016 20:02:58 -0600 X-Authority-Analysis: v=2.1 cv=KLfJUj1o c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=CH0kA5CcgfcA:10 a=20KFwNOVAAAA:8 a=oD1Hb0p_TWP2k9qn5_0A:9 a=e_O65bzb51kRm2y5VmPK:22 Received: from 174-16-143-211.hlrn.qwest.net ([174.16.143.211]:58322 helo=bapiya) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.86_1) (envelope-from ) id 1buVME-0006K3-VC; Wed, 12 Oct 2016 20:02:55 -0600 From: Tom Tromey To: Pedro Alves Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFA 14/22] Replace two xmallocs with vector References: <1474949330-4307-1-git-send-email-tom@tromey.com> <1474949330-4307-15-git-send-email-tom@tromey.com> <2bb436df-b6ee-cc2f-c4c1-1a79d6fcdce1@redhat.com> <87mvi9mbu1.fsf@tromey.com> <59640737-f7d2-04aa-418f-9e3c23027be1@redhat.com> Date: Thu, 13 Oct 2016 02:04:00 -0000 In-Reply-To: <59640737-f7d2-04aa-418f-9e3c23027be1@redhat.com> (Pedro Alves's message of "Thu, 13 Oct 2016 02:17:21 +0100") Message-ID: <87eg3lm2et.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Exim-ID: 1buVME-0006K3-VC X-Source-Sender: 174-16-143-211.hlrn.qwest.net (bapiya) [174.16.143.211]:58322 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-SW-Source: 2016-10/txt/msg00343.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: >> Often the performance doesn't matter, and std::vector is safe to use. >> On the other hand XNEWVEC isn't really unsafe -- maybe just mildly less >> clear to gdb newbies. Pedro> Hmm, the code you're touching isn't using XNEWVEC, so I'm not sure Pedro> I know exactly what you're referring to, but I assume you're thinking Pedro> of the xmallocs you're replacing. Yeah. Hmm, if it's xmalloc (I'm looking at one patch where it's XCNEWVEC, but apparently could be XNEWVEC without any loss), then I'm less sure. XNEWVEC is at least reasonably type-safe, but plain xmalloc less so. Anyway once unique_ptr is in I'll update all those patches and we can discuss it more concretely. Tom