From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19375 invoked by alias); 30 Jul 2017 16:23:16 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 19366 invoked by uid 89); 30 Jul 2017 16:23:15 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=H*F:U*tom, H*RU:sk:outboun, HX-HELO:sk:outboun, Hx-spam-relays-external:sk:outboun X-HELO: outbound-ss-1812.hostmonster.com Received: from gproxy1-pub.mail.unifiedlayer.com (HELO outbound-ss-1812.hostmonster.com) (69.89.25.95) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 30 Jul 2017 16:23:13 +0000 Received: from cmgw4 (cmgw5 [10.0.90.85]) by gproxy1.mail.unifiedlayer.com (Postfix) with ESMTP id 6B5CE175BC6 for ; Sun, 30 Jul 2017 10:23:12 -0600 (MDT) Received: from box522.bluehost.com ([74.220.219.122]) by cmgw4 with id r4P91v00A2f2jeq014PCyM; Sun, 30 Jul 2017 10:23:12 -0600 X-Authority-Analysis: v=2.2 cv=aJeAkf1m c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=G3gG6ho9WtcA:10 a=Nv_Iq8Hv0yEXs04GJmMA:9 Received: from c-67-176-62-53.hsd1.co.comcast.net ([67.176.62.53]:34896 helo=bapiya) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.87) (envelope-from ) id 1dbqzl-0034HY-4I; Sun, 30 Jul 2017 10:23:09 -0600 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFA v2 01/24] Introduce and use ui_out_emit_table References: <20170725172107.9799-1-tom@tromey.com> <20170725172107.9799-2-tom@tromey.com> Date: Sun, 30 Jul 2017 16:23:00 -0000 In-Reply-To: (Simon Marchi's message of "Sun, 30 Jul 2017 01:10:43 +0200") Message-ID: <87efsxao7r.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Exim-ID: 1dbqzl-0034HY-4I X-Source-Sender: c-67-176-62-53.hsd1.co.comcast.net (bapiya) [67.176.62.53]:34896 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-Local-Domain: yes X-SW-Source: 2017-07/txt/msg00439.txt.bz2 >>>>> "Simon" == Simon Marchi writes: >> - ALL_BREAKPOINTS (b) >> + ALL_BREAKPOINTS (b) Simon> Shouldn't the scope just under this be indented as well? I think gdb is inconsistent about this, and my rule has always been that whatever Emacs chooses is correct, since I think that's nearly GNU policy. However, I will change it. You may wish to fix the other instances. Tom