From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 76252 invoked by alias); 22 Sep 2017 18:22:05 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 76243 invoked by uid 89); 22 Sep 2017 18:22:05 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 22 Sep 2017 18:22:04 +0000 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D53D82AD63 for ; Fri, 22 Sep 2017 18:22:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com D53D82AD63 Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=sergiodj@redhat.com Received: from localhost (unused-10-15-17-193.yyz.redhat.com [10.15.17.193]) by smtp.corp.redhat.com (Postfix) with ESMTPS id ACA7E60466; Fri, 22 Sep 2017 18:22:02 +0000 (UTC) From: Sergio Durigan Junior To: Pedro Alves Cc: GDB Patches Subject: Re: [PATCH v3 3/5] Introduce gdb_tilde_expand References: <20170912042325.14927-1-sergiodj@redhat.com> <20170921225926.23132-1-sergiodj@redhat.com> <20170921225926.23132-4-sergiodj@redhat.com> <2045d081-c89b-e83f-97a7-d4e3397aa476@redhat.com> <87d16i4otu.fsf@redhat.com> <2277cb1a-0aa5-6bc7-d09c-2a8258dc4db6@redhat.com> <87vaka38v7.fsf@redhat.com> <9c8b88d3-45a8-8bd8-eea4-56573201decc@redhat.com> Date: Fri, 22 Sep 2017 18:22:00 -0000 In-Reply-To: <9c8b88d3-45a8-8bd8-eea4-56573201decc@redhat.com> (Pedro Alves's message of "Fri, 22 Sep 2017 19:20:36 +0100") Message-ID: <87efqy386u.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2017-09/txt/msg00690.txt.bz2 On Friday, September 22 2017, Pedro Alves wrote: > On 09/22/2017 07:07 PM, Sergio Durigan Junior wrote: >> On Friday, September 22 2017, Pedro Alves wrote: >> >>>>>> +/* See common/gdb_tilde_expand.h. */ >>>>>> + >>>>>> +std::string >>>>>> +gdb_tilde_expand (const char *dir) >>>>>> +{ >>>>>> + gdb_glob glob (dir, GLOB_TILDE | GLOB_TILDE_CHECK | GLOB_ONLYDIR, NULL); >>>>> >>>>> By my reading of man glob, GLOB_TILDE_CHECK already implies GLOB_TILDE. >>>> >>>> Yes, but I think it pays to be explicit in this case. >>> >>> I think it only adds to confusion. I did "man glob", >>> saw that GLOB_TILDE_CHECK implies GLOB_TILDE and then >>> got to wonder why is GLOB_TILDE being passed explicitly. >> >> Well, I personally don't really see the reason for the confusion here >> since you could have read GLOB_TILDE's entry as well and noticed that >> there is nothing fancy being done here, but I respect your way of >> thinking, so I will just remove GLOB_TILDE_CHECK. > > I did not suggest to remove GLOB_TILDE_CHECK. Sorry, my bad, I meant "remove GLOB_TILDE". -- Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/