From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 38806 invoked by alias); 6 Sep 2018 12:43:05 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 38786 invoked by uid 89); 6 Sep 2018 12:43:04 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gateway24.websitewelcome.com Received: from gateway24.websitewelcome.com (HELO gateway24.websitewelcome.com) (192.185.50.93) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 06 Sep 2018 12:43:02 +0000 Received: from cm15.websitewelcome.com (cm15.websitewelcome.com [100.42.49.9]) by gateway24.websitewelcome.com (Postfix) with ESMTP id 000327122 for ; Thu, 6 Sep 2018 07:43:00 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id xtbtfEUnubXuJxtcNfYUTa; Thu, 06 Sep 2018 07:43:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=mL6yYxyHpIBtHOvCI5ApLgti6Mkx4nKlf4veVRX047U=; b=ZDThZTYCu2ZmChDOn2finQIG4R hiH4L6wOTsqYxOTmMLEF+ZYut0auE1+QCqRIx3W/IZWS541vmY6Zvs1hEfcBHB3XmqgIFHUWuL1Nk WLRQ6h+hkkDTJivOUkMR+f/U3; Received: from 75-166-85-72.hlrn.qwest.net ([75.166.85.72]:41548 helo=pokyo) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1fxtbt-003fNK-6h; Thu, 06 Sep 2018 07:42:09 -0500 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , Keith Seitz , Subject: Re: [PATCH] compile: Remove non-const reference parameters References: <1535647635-9566-1-git-send-email-simon.marchi@ericsson.com> <87lg8m1tv9.fsf@tromey.com> <921fe52d-0556-905d-88cb-6092362bcfea@ericsson.com> Date: Thu, 06 Sep 2018 12:43:00 -0000 In-Reply-To: <921fe52d-0556-905d-88cb-6092362bcfea@ericsson.com> (Simon Marchi's message of "Thu, 6 Sep 2018 11:25:57 +0100") Message-ID: <87efe6kdb3.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-09/txt/msg00096.txt.bz2 >>>>> "Simon" == Simon Marchi writes: Simon> Good point. How is this? The only change is in enter_scope and its Simon> callers. Looks reasonable to me. Tom