From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 92394 invoked by alias); 16 Sep 2018 13:01:11 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 54579 invoked by uid 89); 16 Sep 2018 13:00:50 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,TIME_LIMIT_EXCEEDED autolearn=unavailable version=3.3.2 spammy= X-HELO: gateway36.websitewelcome.com Received: from gateway36.websitewelcome.com (HELO gateway36.websitewelcome.com) (192.185.187.5) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 16 Sep 2018 13:00:25 +0000 Received: from cm15.websitewelcome.com (cm15.websitewelcome.com [100.42.49.9]) by gateway36.websitewelcome.com (Postfix) with ESMTP id 1A929400D8942 for ; Sun, 16 Sep 2018 07:05:21 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 1WeXgNFhpbXuJ1WefgfXO2; Sun, 16 Sep 2018 08:00:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=8Myz9KDmDizwRsyGQisWFjVhhrneyKSAC/EAIA9YfNI=; b=mhvoaTfChNLzWyhJ0xTua90O+d Hh7jQMiFEY7zoQfWnlPF62SGH2U1T7FA0urA6v282gRIRM8mmft3AzxgsVxU/Vnlr7s+ZhwK3Hagd IdGVbu02dA4LuieVBR819RJ7g; Received: from 97-122-190-66.hlrn.qwest.net ([97.122.190.66]:46218 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1g1WeW-00450q-Ln; Sun, 16 Sep 2018 07:59:52 -0500 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 1/4] Change pspace_to_pspace_object to return a new reference References: <20180913053007.11780-1-tom@tromey.com> <20180913053007.11780-2-tom@tromey.com> Date: Sun, 16 Sep 2018 13:01:00 -0000 In-Reply-To: (Simon Marchi's message of "Sat, 15 Sep 2018 21:57:55 -0400") Message-ID: <87efdtpph4.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-09/txt/msg00540.txt.bz2 >>>>> "Simon" == Simon Marchi writes: Simon> Ah ok, this is the code I added recently, that's why. I think changing it to Simon> return pspace_to_pspace_object (pspace).release (); Simon> should work. Yep, I got this on rebasing and did what you suggest here. Tom