From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 49705 invoked by alias); 3 Oct 2018 21:05:28 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 49694 invoked by uid 89); 3 Oct 2018 21:05:28 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gateway33.websitewelcome.com Received: from gateway33.websitewelcome.com (HELO gateway33.websitewelcome.com) (192.185.145.23) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 03 Oct 2018 21:05:26 +0000 Received: from cm15.websitewelcome.com (cm15.websitewelcome.com [100.42.49.9]) by gateway33.websitewelcome.com (Postfix) with ESMTP id 87BE553D7 for ; Wed, 3 Oct 2018 16:05:24 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 7oKEgVZGm8YaU7oKXgyMYc; Wed, 03 Oct 2018 16:05:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=YB32dT9kjWYselRSS+QdsvRzUwaifiGK6mGSCVj82Ds=; b=XEthUXEA3p1CfOA29d9DsGt/3w M4hhZmaNhhggL8xfygJqma3/cYORUVUif62yBBUtAecfxFC7e9TGC3Ftr6N6Llkvt2ELpRZPk72Lo 00PQ7zhQzJmOvEAU1W5hRy5Bx; Received: from 97-122-190-66.hlrn.qwest.net ([97.122.190.66]:49572 helo=pokyo) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1g7oKE-0006Ar-N7; Wed, 03 Oct 2018 16:04:54 -0500 From: Tom Tromey To: Pedro Alves Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH v2 02/10] Change dwarf2_frame_state_reg_info::reg to be std::vector References: <20181002044420.17628-1-tom@tromey.com> <20181002044420.17628-3-tom@tromey.com> Date: Wed, 03 Oct 2018 21:05:00 -0000 In-Reply-To: (Pedro Alves's message of "Wed, 3 Oct 2018 18:27:57 +0100") Message-ID: <87efd6kah6.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-10/txt/msg00093.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: Pedro> On 10/02/2018 05:44 AM, Tom Tromey wrote: >> This changes dwarf2_frame_state_reg_info::reg to be a std::vector. >> This avoids undefined behavior in the copy constructor when the >> original object does not have any registers. Pedro> I don't have anything to say against the patch, I think it's a nice Pedro> cleanup regardless, but could you expand this log a little to point Pedro> out exactly what is triggering the undefined behavior. I guess we're Pedro> passing NULL to the memcpy? Yes, that was the issue. Simon asked for this cleanup IIRC. I've added a note about this to the commit message. Tom