From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16739 invoked by alias); 25 Mar 2019 16:46:56 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 16728 invoked by uid 89); 25 Mar 2019 16:46:55 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.9 required=5.0 tests=AWL,BAYES_00,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=no version=3.3.1 spammy=H*f:sk:87r2azk, H*f:sk:87mulnk, somewhere X-HELO: gateway33.websitewelcome.com Received: from gateway33.websitewelcome.com (HELO gateway33.websitewelcome.com) (192.185.146.130) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 25 Mar 2019 16:46:54 +0000 Received: from cm17.websitewelcome.com (cm17.websitewelcome.com [100.42.49.20]) by gateway33.websitewelcome.com (Postfix) with ESMTP id B66A851FE8 for ; Mon, 25 Mar 2019 11:46:49 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 8SkLhaeUf90on8SkLhpz0J; Mon, 25 Mar 2019 11:46:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=UiCEEaFcEyFqr+BRoNzl3Qe0xwtWKSdW0l5o+LNXDLg=; b=qPaXbdTv0oGII0AntoykRHyzBU Foi1hCRP/K6RIO5enZpgffMwpJnmWi4XLcMEmzG7uSGEK7Q1v3S8gD1ZLjDl7DVRimjPGHjVulaAH DjhMfBN64Gv4T06zxYFJR+Kir; Received: from 174-29-37-56.hlrn.qwest.net ([174.29.37.56]:55660 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1h8SkL-004Cia-58; Mon, 25 Mar 2019 11:46:49 -0500 From: Tom Tromey To: Pedro Alves Cc: Tom Tromey , Sergio Durigan Junior , Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH] Merge handle_inferior_event and handle_inferior_event_1 References: <20190320140846.13031-1-tromey@adacore.com> <87r2azkhmq.fsf@redhat.com> <87mulnkcab.fsf@redhat.com> <87a7hjj7aw.fsf@tromey.com> Date: Mon, 25 Mar 2019 16:46:00 -0000 In-Reply-To: (Pedro Alves's message of "Mon, 25 Mar 2019 16:34:44 +0000") Message-ID: <87ef6uj408.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-03/txt/msg00549.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: Pedro> So it looks like your patch made it so that the value in question Pedro> avoids the crash because the value in question is no longer in the Pedro> all_values vector by the time gdb is tearing down? Makes sense. Pedro> Open questions then would be: Pedro> - what was the exception in question that was thrown from Pedro> within handle_inferior_event_1? (And if there was Pedro> no exception, then the theory above is incorrect.) Pedro> - why don't non-temporary xmethod values put in the value history Pedro> cause a similar crash at tear down time? Also, if a crash can occur during value destruction like this, then I think it must indicate a bug somewhere else, like invalid reference counting somewhere. Tom