From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15868 invoked by alias); 3 May 2019 20:50:11 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 15856 invoked by uid 89); 3 May 2019 20:50:11 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-4.8 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_1,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 03 May 2019 20:50:09 +0000 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8FE653081244; Fri, 3 May 2019 20:50:08 +0000 (UTC) Received: from localhost (unused-10-15-17-196.yyz.redhat.com [10.15.17.196]) by smtp.corp.redhat.com (Postfix) with ESMTP id 667E9608A5; Fri, 3 May 2019 20:50:08 +0000 (UTC) From: Sergio Durigan Junior To: Tom de Vries Cc: gdb-patches@sourceware.org Subject: Re: buildbot config cc-with-index not functional References: <20190503105847.GA9448@delia> <4f515dbf-69ad-1bf0-d16b-f9bc7150e6c8@suse.de> <87k1f7nwvc.fsf@redhat.com> <3af2889a-4c04-ba8d-1c66-d2a1b1e73307@suse.de> Date: Fri, 03 May 2019 20:50:00 -0000 In-Reply-To: <3af2889a-4c04-ba8d-1c66-d2a1b1e73307@suse.de> (Tom de Vries's message of "Fri, 3 May 2019 22:26:35 +0200") Message-ID: <87ef5fntz3.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2019-05/txt/msg00081.txt.bz2 On Friday, May 03 2019, Tom de Vries wrote: > On 03-05-19 21:47, Sergio Durigan Junior wrote: >> On Friday, May 03 2019, Tom de Vries wrote: >> >>> [ was: Re: [committed][gdb/testsuite] Add cc-with-gdb-index.exp ] >>> >>> Hi, >>> >>> I've just added a target board cc-with-gdb-index.exp, to make it easy to >>> test using cc-with-tweaks.sh -i. >>> >>> Then I stumbled upon the build bot config Fedora-x86_64-cc-with-index, >>> and I took a look at the test results. >>> >>> I noticed that a test failing with cc-with-gdb-index.exp, >>> gdb.base/cache-index.exp (see PR24516 - "cc-with-gdb-index failures") is >>> passing in the cc-with-index config. >>> >>> I managed to reproduce that pass using the way the config uses >>> cc-with-tweaks.sh: >>> ... >>> $ make -k check \ >>> 'CC_FOR_TARGET=/bin/sh gdb/contrib/cc-with-tweaks.sh -i gcc' \ >>> 'CXX_FOR_TARGET=/bin/sh gdb/contrib/cc-with-tweaks.sh -i g++' \ >>> -j4 \ >>> FORCE_PARALLEL=1 \ >>> TS=1 >>> ... >>> >>> So, AFAIU, the cc-with-index buildbot config does not actually test >>> using cc-with-tweaks.sh -i, as it intends to. >> >> Ah... Thanks for bringing this up. IIUC, CC_FOR_TARGET and >> CXX_FOR_TARGET need to be passed inside RUNTESTFLAGS. I think that's >> the problem. Can you please check if you can reproduce the bug when you >> do that? >> > > Confirmed, using: > ... > $ make -k check "RUNTESTFLAGS='CC_FOR_TARGET=/bin/sh > $pwd/gdb/contrib/cc-with-tweaks.sh -i gcc' 'CXX_FOR_TARGET=/bin/sh > $pwd/gdb/contrib/cc-with-tweaks.sh -i g++' gdb.base/index-cache.exp" > ... > I can reproduce the bug. Thanks. >> Also, I'm happy to know there's now a cc-with-gdb-index.exp flag. So the >> buildbot can just use RUNTESTFLAGS='--target_board >> cc-with-gdb-index.exp', right? >> > > Yep, that's the idea. Thanks, I'll update the config file now. -- Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/