From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 85073 invoked by alias); 31 May 2019 20:10:26 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 85062 invoked by uid 89); 31 May 2019 20:10:26 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-6.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=dealt, H*RU:cmsmtp, H*r:cmsmtp, HX-Spam-Relays-External:cmsmtp X-HELO: gateway34.websitewelcome.com Received: from gateway34.websitewelcome.com (HELO gateway34.websitewelcome.com) (192.185.150.114) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 31 May 2019 20:10:23 +0000 Received: from cm14.websitewelcome.com (cm14.websitewelcome.com [100.42.49.7]) by gateway34.websitewelcome.com (Postfix) with ESMTP id EE4EA484EA for ; Fri, 31 May 2019 15:10:21 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id Wnr3hqnbX2qH7Wnr3h48bp; Fri, 31 May 2019 15:10:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=wstdByjdeD+r9Ca8048NlhL4xuKWHMr9GQ3AwSaRcCQ=; b=hRuwZtJS+bVxzKo9f5iSmeqxi/ yb1yxp+/E2sGPJNZT+cg1MkiHvr8RlNWT4fBGGiBXUb6iwEt2gqvTAQBlTO3WGdY5y0niS2Bikipd 9EkzzUixbzv4kSSelrkTZdpLw; Received: from 174-29-48-168.hlrn.qwest.net ([174.29.48.168]:56790 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1hWnr3-003UV2-Kk; Fri, 31 May 2019 15:10:21 -0500 From: Tom Tromey To: Philippe Waroquiers Cc: gdb-patches@sourceware.org Subject: Re: [RFA 1/4] Add highlight style, title style, fputs_highlighted. Improve 'show style' References: <20190531131903.21203-1-philippe.waroquiers@skynet.be> <20190531131903.21203-2-philippe.waroquiers@skynet.be> Date: Fri, 31 May 2019 20:10:00 -0000 In-Reply-To: <20190531131903.21203-2-philippe.waroquiers@skynet.be> (Philippe Waroquiers's message of "Fri, 31 May 2019 15:19:00 +0200") Message-ID: <87ef4epeqb.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-05/txt/msg00754.txt.bz2 >>>>> "Philippe" == Philippe Waroquiers writes: Philippe> Have 'show style' and its subcommands using a style to style its output. Philippe> This allows the GDB user or developer to use 'show style' to visually see Philippe> with one command how all the current styles look like. Thanks. Philippe> +static void Philippe> +do_show (const char *what, struct ui_file *file, Philippe> + struct cmd_list_element *cmd, Philippe> + const char *value) This needs some introductory comment. Philippe> +{ Philippe> + cli_style_option *cso = (cli_style_option *) get_cmd_context (cmd); Philippe> + fputs_filtered (_("The \""), file); Philippe> + fprintf_styled (file, cso->style (), "%s", cso->name ()); Can't this use fputs_styled instead? It seems like the output might be a bit odd, in that the text will refer to one aspect of the style, but it will be styled using the entire style. Philippe> +readibility.")); Typo, "readability". Philippe> + /* Output the part before pmatch with current style. */ Philippe> + while (pmatch.rm_so > 0) Philippe> + { Philippe> + fputc_filtered (*str, stream); Philippe> + pmatch.rm_so--; Philippe> + str++; Sometimes I wish the lower layers of the I/O system dealt with string views instead of terminated strings... I wondered if "highlight" was too generic a name, but I suppose it fits well enough. The only other idea I came up with was "search", which in the end didn't really seem better. Tom