From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 99308 invoked by alias); 1 Jul 2019 17:38:26 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 99297 invoked by uid 89); 1 Jul 2019 17:38:26 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-5.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy= X-HELO: gateway20.websitewelcome.com Received: from gateway20.websitewelcome.com (HELO gateway20.websitewelcome.com) (192.185.54.2) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 01 Jul 2019 17:38:24 +0000 Received: from cm14.websitewelcome.com (cm14.websitewelcome.com [100.42.49.7]) by gateway20.websitewelcome.com (Postfix) with ESMTP id 7FFA4400D1C8C for ; Mon, 1 Jul 2019 11:36:20 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id i0FyhUOiu2qH7i0Fyhc4Ug; Mon, 01 Jul 2019 12:38:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=aJO0PLW8nN22nFAHuJzdQfr698WHmTBlCiiFYO+zwSU=; b=RY229NUk5pBDGT22Lvz/0KEDcA OTHuDfkPXjeJG2FG6v1Vm6HAYPxQPcPC3d5oK4mQ+eFAiyg8XP1ZAb7OyfvIXbM/SchW66Q6o1Urp iBuYu1aD9X82wnX2k3IBHwYzA; Received: from 174-29-48-143.hlrn.qwest.net ([174.29.48.143]:55618 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1hi0Fy-001eb1-FN; Mon, 01 Jul 2019 12:38:22 -0500 From: Tom Tromey To: Pedro Alves Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: ui_out format strings for fields and styles (Re: [PATCH] Style "pwd" output) References: <20190605020116.1550-1-tom@tromey.com> <1ee4bd6b-4cdf-f3a9-74af-0843bf123a8b@redhat.com> <87lfygi1x0.fsf@tromey.com> <32872d6a-15d6-9718-59ae-957694e114c9@redhat.com> <87imtjhj6b.fsf@tromey.com> <625cd0ba-058d-d4bf-8ba3-8676f335b0f3@redhat.com> <87blzbep47.fsf@tromey.com> <2180f72f-da10-5333-90a1-666ba3bd145e@redhat.com> <87imtjbrmx.fsf@tromey.com> <871s056yjw.fsf@tromey.com> <87wohx5hir.fsf@tromey.com> <4e543ef2-eec3-b82c-a84a-a107e1ef2bc2@redhat.com> <3ff7dd5c-334b-3bcc-e43e-a350b3008304@redhat.com> Date: Mon, 01 Jul 2019 17:38:00 -0000 In-Reply-To: <3ff7dd5c-334b-3bcc-e43e-a350b3008304@redhat.com> (Pedro Alves's message of "Mon, 1 Jul 2019 14:17:52 +0100") Message-ID: <87ef39psdu.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-07/txt/msg00019.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: Pedro> I'm not sure whether we could portably save the varargs like Pedro> above, though. So that might be moot. I'm not sure it matters a whole lot. I looked through all the field_fmt calls, and many of them can be replaced with some other call. The few that remain can be rewritten in terms of string_printf if need be. Pedro> - uiout->text ("[Inferior "); Pedro> - uiout->text (plongest (inf->num)); Pedro> - uiout->text (" ("); Pedro> - uiout->text (pidstr.c_str ()); Pedro> - uiout->text (") exited with code "); Pedro> - uiout->field_fmt ("exit-code", "0%o", (unsigned int) exitstatus); Pedro> - uiout->text ("]\n"); Pedro> + std::string exit_code_str Pedro> + = string_printf ("0%o", (unsigned int) exitstatus); Pedro> + uiout->message ("[Inferior %s (%s) exited with code %pF]\n", Pedro> + plongest (inf->num), pidstr.c_str (), Pedro> + string_field ("exit-code", exit_code_str.c_str ())); This is so much better. Tom