From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20174 invoked by alias); 10 Jul 2019 15:03:06 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 20082 invoked by uid 89); 10 Jul 2019 15:03:01 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-7.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy= X-HELO: gateway31.websitewelcome.com Received: from gateway31.websitewelcome.com (HELO gateway31.websitewelcome.com) (192.185.143.31) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 10 Jul 2019 15:03:00 +0000 Received: from cm12.websitewelcome.com (cm12.websitewelcome.com [100.42.49.8]) by gateway31.websitewelcome.com (Postfix) with ESMTP id 304F33258 for ; Wed, 10 Jul 2019 10:02:57 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id lE7VhyplYiQerlE7VhRVku; Wed, 10 Jul 2019 10:02:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=wHlbDoa3zP2QqVYgVU6Q8KhayyNdiEIImIBAHbK7wVA=; b=ZHJANc8riu9Lc2GoQQVxV5kvfd Qrx9d/Mg0Ii6NHE5xoZ2t6zNDS3AYnSI5IyDpErUbqHwOT0LC/t/IDQr13vMVHLPmuXd0X7nJq+eY +YGt083xOVPvi8nDEWx8dQiK0; Received: from 97-122-178-82.hlrn.qwest.net ([97.122.178.82]:49892 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1hlE7U-000dOM-UA; Wed, 10 Jul 2019 10:02:57 -0500 From: Tom Tromey To: Andrew Burgess Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCHv2 5/5] gdb: Better support for dynamic properties with negative values References: <672dc208d6dfb9f068eb635e02bf85abb9630c74.1557439866.git.andrew.burgess@embecosm.com> <87lfyycn6i.fsf@tromey.com> <20190610221701.GO23204@embecosm.com> Date: Wed, 10 Jul 2019 15:03:00 -0000 In-Reply-To: <20190610221701.GO23204@embecosm.com> (Andrew Burgess's message of "Mon, 10 Jun 2019 23:17:01 +0100") Message-ID: <87ef2yexun.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-07/txt/msg00246.txt.bz2 >>>>> "Andrew" == Andrew Burgess writes: I meant to reply to this but forgot to. I'm sorry about that. >> I wonder whether this should be using ULONGEST rather than CORE_ADDR >> now. Andrew> I don't think you're wrong, but I'm hoping I can convince you to let Andrew> me punt this change for now, it would be fairly big change to the Andrew> dwarf property fetching code. What we have seems to hang together for Andrew> now, so I'd prefer to get this change in first. Yes, I think it's fine to just move forward with the patch you've written. Tom