From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7523 invoked by alias); 15 Oct 2019 17:09:48 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 7511 invoked by uid 89); 15 Oct 2019 17:09:48 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-6.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:629, google X-HELO: gateway23.websitewelcome.com Received: from gateway23.websitewelcome.com (HELO gateway23.websitewelcome.com) (192.185.49.179) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 15 Oct 2019 17:09:46 +0000 Received: from cm14.websitewelcome.com (cm14.websitewelcome.com [100.42.49.7]) by gateway23.websitewelcome.com (Postfix) with ESMTP id D851E67866 for ; Tue, 15 Oct 2019 12:09:42 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id KQKMii7qYBnGaKQKMior47; Tue, 15 Oct 2019 12:09:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=KesoFuR0mFhBjohCzXFjKS7lpJSD0HvKT5kLzzaTs9U=; b=xL1t2N8NHUcqE7M1iYoNULtXsO WkADQFRFmEMKFcz9WVA4/kqeyq8WTsD4DrvxiyOaLgvRGHvwruRrxp8zoQ3bj2JkRaMUSpxYBlZj7 79h6lp/NCSgM2c7eZKnttQK5t; Received: from 174-29-53-230.hlrn.qwest.net ([174.29.53.230]:55186 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1iKQKM-000pPq-3l; Tue, 15 Oct 2019 11:09:42 -0600 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , "Tom de Vries \(Code Review\)" , gdb-patches@sourceware.org, tdevries@suse.de, sergiodj@sergiodj.net, andrew.burgess@embecosm.com Subject: Re: Gerrit request References: <20191014160117.2C9AA29ECF@gnutoolchain-gerrit.osci.io> <875zkrtd56.fsf_-_@tromey.com> Date: Tue, 15 Oct 2019 17:09:00 -0000 In-Reply-To: (Simon Marchi's message of "Mon, 14 Oct 2019 21:15:58 -0400") Message-ID: <87eezeorzg.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-10/txt/msg00438.txt.bz2 >>>>> "Simon" == Simon Marchi writes: Tom> This would be a lot better if the email included more of the patch Tom> context. Simon> It doesn't seem to be possible out of the box. The template can only work Simon> with the data passed by Gerrit. For a line comment, we only get the single Simon> line it refers to: Simon> https://gerrit.googlesource.com/gerrit/+/refs/heads/master/java/com/google/gerrit/server/mail/send/CommentSender.java#328 That's unfortunate. For me this makes the patch reviews pretty unreadable on the list. Maybe a gerrit feature request is in order. Tom