Re: [PATCH v2 00/24] Multi-target support

Pedro Alves
2020-08-12T18:45:55Z

On 8/7/20 11:43 PM, Kevin Buettner wrote:
> On Thu, 6 Aug 2020 16:16:10 +0100
> Pedro Alves <pedro@palves.net> wrote:
>
>> On 8/4/20 4:30 AM, Kevin Buettner via Gdb-patches wrote:
>>> On Fri, 10 Jan 2020 20:13:22 +0000
>>> Pedro Alves <palves@redhat.com> wrote:
>>>
>>>> I've now merged the multi-target work to master, including
>>>> the couple follow up patches developed and discussed on this
>>>> thread.
>>>
>>> I've run into a regression stemming from this commit:
>>>
>>> 5b6d1e4fa4 (HEAD, refs/bisect/bad) Multi-target support
>>>
>>> More info in Bug 26336:
>>>
>>> https://sourceware.org/bugzilla/show_bug.cgi?id=26336
>>>
>>> (I thought at first that I introduced this problem with my recent
>>> core file work, but realized that was not the case after I disabled
>>> it. I then did a bisection starting from late last year.)
>>
>> Thanks for the bisect and the initial analysis. This patch fixes
>> it for me. No regressions for me on either -m32 nor -m64, and
>> the corefile.exp regression is fixed. Let me know what you think.
>
> Your analysis make sense to me and the patch looks good.
>
> I've tested your patch locally and no longer see the corefile.exp
> regression when testing w/ x86_64/-m32 (or with just x86_64).
>

Thanks guys. I've merged it now.

Pedro Alves